Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/metrics/v8_object_stats.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: AppendExtraBrowserArgs Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/perf/metrics/io.py ('K') | « tools/perf/metrics/smoothness.py ('k') | tools/telemetry/telemetry/core/browser_options.py » ('j') | tools/telemetry/telemetry/core/browser_options.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/v8_object_stats.py
diff --git a/tools/perf/metrics/v8_object_stats.py b/tools/perf/metrics/v8_object_stats.py
index 79b0fad92e0d8f57e7d6c9ceb456fc1465b9fdef..58a726b860f177a2fcaf30cd7158209c5348c506 100644
--- a/tools/perf/metrics/v8_object_stats.py
+++ b/tools/perf/metrics/v8_object_stats.py
@@ -160,10 +160,11 @@ class V8ObjectStatsMetric(Metric):
@classmethod
def CustomizeBrowserOptions(cls, options):
- options.AppendExtraBrowserArg('--enable-stats-table')
- options.AppendExtraBrowserArg('--enable-benchmarking')
- options.AppendExtraBrowserArg(
- '--js-flags=--track_gc_object_stats --expose_gc')
+ options.AppendExtraBrowserArgs([
+ '--enable-stats-table',
+ '--enable-benchmarking',
+ '--js-flags=--track_gc_object_stats --expose_gc'
+ ])
def Start(self, page, tab):
"""Do Nothing."""
« tools/perf/metrics/io.py ('K') | « tools/perf/metrics/smoothness.py ('k') | tools/telemetry/telemetry/core/browser_options.py » ('j') | tools/telemetry/telemetry/core/browser_options.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698