Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2351193002: Fix memory leaking on ClosePage. (Closed)

Created:
4 years, 3 months ago by snake
Modified:
4 years, 3 months ago
Reviewers:
npm, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix memory leaking on ClosePage. BUG=79367, 48791 The fonts was not cleared after unloading pages. Test pdf: http://www.nasa.gov/pdf/750614main_NASA_FY_2014_Budget_Estimates-508.pdf For this file, we have ~5 fonts per page, which equal ~1 Mb per page. In this PDF we have 670 pages, as result after slow scrolling(reading) full document we have ~600 Mb fonts data in memory. Memory usage of PDF Plugin: before this CL: ~660 Mb after this CL: ~100 Mb This is last part of reverted CL: Original CL: https://codereview.chromium.org/2158023002 Revert reason: BUG=647612 Fix bug CL: https://codereview.chromium.org/2350193003 Previous CL: https://codereview.chromium.org/2350243002 Committed: https://pdfium.googlesource.com/pdfium/+/a6df44456956914e86b9d9af722b30628c45f208

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix review issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 7 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
snake
4 years, 3 months ago (2016-09-20 18:25:14 UTC) #3
dsinclair
https://codereview.chromium.org/2351193002/diff/1/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp File core/fpdfapi/fpdf_page/fpdf_page_doc.cpp (right): https://codereview.chromium.org/2351193002/diff/1/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp#newcode481 core/fpdfapi/fpdf_page/fpdf_page_doc.cpp:481: if (profile->use_count() == 1) { Can we make this ...
4 years, 3 months ago (2016-09-20 18:28:18 UTC) #4
snake
https://codereview.chromium.org/2351193002/diff/1/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp File core/fpdfapi/fpdf_page/fpdf_page_doc.cpp (right): https://codereview.chromium.org/2351193002/diff/1/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp#newcode481 core/fpdfapi/fpdf_page/fpdf_page_doc.cpp:481: if (profile->use_count() == 1) { On 2016/09/20 18:28:18, dsinclair ...
4 years, 3 months ago (2016-09-20 18:45:44 UTC) #5
dsinclair
lgtm
4 years, 3 months ago (2016-09-20 18:46:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351193002/20001
4 years, 3 months ago (2016-09-20 18:46:28 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 18:59:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/a6df44456956914e86b9d9af722b30628c45...

Powered by Google App Engine
This is Rietveld 408576698