Fix "heap use after free" bug.

Fix "heap use after free" bug.

BUG=647612
Committed: https://pdfium.googlesource.com/pdfium/+/52d6868075ff23d5081d4c0185c7619f4c084553

[snake, 2016-09-19 18:12:25]

Description was changed from

==========
Fix "heap use after free" bug.

BUG=647612
==========

to

==========
Fix "heap use after free" bug.

BUG=647612
==========

[snake, 2016-09-19 18:12:25]

art-snake@yandex-team.ru changed reviewers:
+ dsinclair@chromium.org, npm@chromium.org

[dsinclair, 2016-09-19 18:16:12]

https://codereview.chromium.org/2350193003/diff/1/core/fpdfapi/fpdf_render/fp...
File core/fpdfapi/fpdf_render/fpdf_render_image.cpp (right):

https://codereview.chromium.org/2350193003/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render_image.cpp:987: CPDF_Object* pCSObj =
nullptr;
nit: Move this down to 993 as it isn't used outside the if()'s below.

[snake, 2016-09-19 18:25:31]

On 2016/09/19 18:16:12, dsinclair wrote:
>
https://codereview.chromium.org/2350193003/diff/1/core/fpdfapi/fpdf_render/fp...
> File core/fpdfapi/fpdf_render/fpdf_render_image.cpp (right):
> 
>
https://codereview.chromium.org/2350193003/diff/1/core/fpdfapi/fpdf_render/fp...
> core/fpdfapi/fpdf_render/fpdf_render_image.cpp:987: CPDF_Object* pCSObj =
> nullptr;
> nit: Move this down to 993 as it isn't used outside the if()'s below.

Done

[dsinclair, 2016-09-19 18:26:50]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-19 18:26:51]

lgtm

[commit-bot: I haz the power, 2016-09-19 18:26:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:28:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:28:08]

Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)
  mac on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac/builds/2093)
  mac_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa/builds/...)

[snake, 2016-09-19 18:32:09]

The CQ bit was checked by art-snake@yandex-team.ru

[snake, 2016-09-19 18:32:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2350193003/#ps40001
(title: "Rebase to Head.")

[commit-bot: I haz the power, 2016-09-19 18:32:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:51:31]

Description was changed from

==========
Fix "heap use after free" bug.

BUG=647612
==========

to

==========
Fix "heap use after free" bug.

BUG=647612

Committed:
https://pdfium.googlesource.com/pdfium/+/52d6868075ff23d5081d4c0185c7619f4c08...
==========

[commit-bot: I haz the power, 2016-09-19 18:51:32]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/52d6868075ff23d5081d4c0185c7619f4c08...