Make CFX_FontCache global

Refactor CFX_FontCache to have only one in GE Module.

After this CL: only one global CFX_FontCache used. Any cached items
from it, are released, when they are not being used.

This is restore part of reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003

Committed: https://pdfium.googlesource.com/pdfium/+/9972ff99285cea12a20026136e98c1e635a15010

[snake, 2016-09-19 18:55:05]

Description was changed from

==========
Fix memory leaking on ClosePage.
CFX_FontCache refactoring:
 after this CL: Only one global CFX_FontCache used. Any cached items from it,
are released, when its are not used.

 BUG=79367, 48791

 The fonts was not cleared after unloading pages.

 Test pdf:
http://www.nasa.gov/pdf/750614main_NASA_FY_2014_Budget_Estimates-508.pdf
 For this file, we have ~5 fonts per page, which equal ~1 Mb per page.
 In this PDF we have 670 pages, as result after slow scrolling(reading) full
document we have ~600 Mb fonts data in memory.

 memory usage of PDF Plugin:
  before this CL: ~660 Mb
  after this CL: ~100 Mb

This is restore reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003
==========

to

==========
Fix memory leaking on ClosePage.
CFX_FontCache refactoring:
 after this CL: Only one global CFX_FontCache used. Any cached items from it,
are released, when its are not used.

 BUG=79367, 48791

 The fonts was not cleared after unloading pages.

 Test pdf:
http://www.nasa.gov/pdf/750614main_NASA_FY_2014_Budget_Estimates-508.pdf
 For this file, we have ~5 fonts per page, which equal ~1 Mb per page.
 In this PDF we have 670 pages, as result after slow scrolling(reading) full
document we have ~600 Mb fonts data in memory.

 memory usage of PDF Plugin:
  before this CL: ~660 Mb
  after this CL: ~100 Mb

This is restore reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003
==========

[snake, 2016-09-19 18:55:06]

art-snake@yandex-team.ru changed reviewers:
+ dsinclair@chromium.org, npm@chromium.org

[dsinclair, 2016-09-20 13:02:19]

I think we should break this apart. There is the bit related to fixing the font
leaks and the bit which changes the font cache to use a single cache.

Can we make those two Cls so, if we need to revert again, the revert will be a
lot smaller?

[snake, 2016-09-20 13:19:44]

Description was changed from

==========
Fix memory leaking on ClosePage.
CFX_FontCache refactoring:
 after this CL: Only one global CFX_FontCache used. Any cached items from it,
are released, when its are not used.

 BUG=79367, 48791

 The fonts was not cleared after unloading pages.

 Test pdf:
http://www.nasa.gov/pdf/750614main_NASA_FY_2014_Budget_Estimates-508.pdf
 For this file, we have ~5 fonts per page, which equal ~1 Mb per page.
 In this PDF we have 670 pages, as result after slow scrolling(reading) full
document we have ~600 Mb fonts data in memory.

 memory usage of PDF Plugin:
  before this CL: ~660 Mb
  after this CL: ~100 Mb

This is restore reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003
==========

to

==========
CFX_FontCache refactoring:
 after this CL: Only one global CFX_FontCache used. Any cached items from it,
are released, when its are not used.

This is restore part of reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003
==========

[snake, 2016-09-20 13:41:30]

On 2016/09/20 13:02:19, dsinclair wrote:
> I think we should break this apart. There is the bit related to fixing the
font
> leaks and the bit which changes the font cache to use a single cache.
> 
> Can we make those two Cls so, if we need to revert again, the revert will be a
> lot smaller?

I did remove code related to the fix of font(and other) leaks.

[npm, 2016-09-20 14:14:29]

Description was changed from

==========
CFX_FontCache refactoring:
 after this CL: Only one global CFX_FontCache used. Any cached items from it,
are released, when its are not used.

This is restore part of reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003
==========

to

==========
Refactor CFX_FontCache to have only one in GE Module.

After this CL: only one global CFX_FontCache used. Any cached items from it, are
released, when they are not being used.

This is restore part of reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003
==========

[npm, 2016-09-20 14:14:47]

Description was changed from

==========
Refactor CFX_FontCache to have only one in GE Module.

After this CL: only one global CFX_FontCache used. Any cached items from it, are
released, when they are not being used.

This is restore part of reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003
==========

to

==========
Refactor CFX_FontCache to have only one in GE Module.

After this CL: only one global CFX_FontCache used. Any cached items
from it, are released, when they are not being used.

This is restore part of reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003
==========

[npm, 2016-09-20 14:16:42]

On 2016/09/20 13:41:30, snake wrote:
> On 2016/09/20 13:02:19, dsinclair wrote:
> > I think we should break this apart. There is the bit related to fixing the
> font
> > leaks and the bit which changes the font cache to use a single cache.
> > 
> > Can we make those two Cls so, if we need to revert again, the revert will be
a
> > lot smaller?
> 
> I did remove code related to the fix of font(and other) leaks.

lgtm if this is exactly the same as 2158023002, after taking out the changes
from fpdf_page_doc.cpp, which correspond to leak fixes.

[npm, 2016-09-20 14:19:32]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-09-20 14:19:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 14:46:28]

Description was changed from

==========
Refactor CFX_FontCache to have only one in GE Module.

After this CL: only one global CFX_FontCache used. Any cached items
from it, are released, when they are not being used.

This is restore part of reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003
==========

to

==========
Refactor CFX_FontCache to have only one in GE Module.

After this CL: only one global CFX_FontCache used. Any cached items
from it, are released, when they are not being used.

This is restore part of reverted CL:
Original CL: https://codereview.chromium.org/2158023002
Revert reason: BUG=647612
Fix bug CL: https://codereview.chromium.org/2350193003

Committed:
https://pdfium.googlesource.com/pdfium/+/9972ff99285cea12a20026136e98c1e635a1...
==========

[commit-bot: I haz the power, 2016-09-20 14:46:29]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/9972ff99285cea12a20026136e98c1e635a1...