Fix for out of scope type parameters in members.

Fix for out of scope type parameters in members.

...by always using the substituted type in members.

This might increase memory usage. However members are mosly used in
method bodies, and we now aggressively flush resolved ASTs from cache.

I don't see any noticeable increase on analyzer + analysis_server code.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5eea83396e0a008f269ec92d4b439be9bc00f01c

[Brian Wilkerson, 2016-09-21 13:52:54]

lgtm

[Paul Berry, 2016-09-21 17:14:23]

lgtm

[scheglov, 2016-09-21 17:19:32]

Description was changed from

==========
Fix for out of scope type parameters in members.

...by always using the substituted type in members.

This might increase memory usage. However members are mosly used in
method bodies, and we now aggressively flush resolved ASTs from cache.

I don't see any noticeable increase on analyzer + analysis_server code.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Fix for out of scope type parameters in members.

...by always using the substituted type in members.

This might increase memory usage. However members are mosly used in
method bodies, and we now aggressively flush resolved ASTs from cache.

I don't see any noticeable increase on analyzer + analysis_server code.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/5eea83396e0a008f269ec92d4b439be9bc00f01c
==========

[scheglov, 2016-09-21 17:19:33]

Committed patchset #1 (id:1) manually as
5eea83396e0a008f269ec92d4b439be9bc00f01c (presubmit successful).

[Paul Berry, 2016-09-21 17:28:52]

On 2016/09/21 17:19:33, scheglov wrote:
> Committed patchset #1 (id:1) manually as
> 5eea83396e0a008f269ec92d4b439be9bc00f01c (presubmit successful).

This CL appears to have broken an analyzer unit test.  Would you mind having a
look?

Details:

ERROR: AstInferredTypeTest |
test_genericMethods_correctlyRecognizeGenericUpperBound
  Test failed: Caught type 'TypeParameterMember' is not a subtype of type
'TypeParameterElementImpl' of 'resynthesized' where
    TypeParameterMember is from package:analyzer/src/dart/element/member.dart
    TypeParameterElementImpl is from
package:analyzer/src/dart/element/element.dart
  
  pkg/analyzer/test/src/summary/resynthesize_common.dart 987:62     
AbstractResynthesizeTest.compareTypeParameterElements
  pkg/analyzer/test/src/summary/resynthesize_common.dart 1067:9     
AbstractResynthesizeTest.compareTypes
  pkg/analyzer/test/src/summary/resynthesize_common.dart 726:7      
AbstractResynthesizeTest.compareExecutableElements
  pkg/analyzer/test/src/summary/resynthesize_common.dart 860:5      
AbstractResynthesizeTest.compareMethodElements
  pkg/analyzer/test/src/summary/resynthesize_common.dart 242:7      
AbstractResynthesizeTest.compareClassElements
  pkg/analyzer/test/src/summary/resynthesize_common.dart 260:7      
AbstractResynthesizeTest.compareCompilationUnitElements
  pkg/analyzer/test/src/summary/resynthesize_common.dart 97:5       
AbstractResynthesizeTest.checkLibraryElements
  pkg/analyzer/test/src/summary/resynthesize_ast_test.dart 675:5    
AstInferredTypeTest._checkSource
  pkg/analyzer/test/src/summary/resynthesize_ast_test.dart 54:40    
AstInferredTypeTest.checkFile
  pkg/analyzer/test/src/task/strong/inferred_type_test.dart 1796:5  
AbstractResynthesizeTest&_AstResynthesizeTestMixin&InferredTypeMixin.test_genericMethods_correctlyRecognizeGenericUpperBound
  dart:mirrors-patch/mirrors_impl.dart 534                          
_LocalInstanceMirror._invoke
  dart:mirrors-patch/mirrors_impl.dart 530                          
_LocalInstanceMirror.invoke
  package:test_reflective_loader/test_reflective_loader.dart 163:35 
_runTest.<fn>
  dart:async/zone.dart 1158                                         
_rootRunUnary
  dart:async/zone.dart 1037                                         
_CustomZone.runUnary
  dart:async/future_python tools/test.py -aia32 --checked -mrelease -t60
pkg/analyzer/test/src/summary/resynthesize_ast_testimpl.dart 131                
                   _FutureListener.handleValue
  dart:async/future_impl.dart 637                                   
_Future._propagateToListeners.handleValueCallback
  dart:async/future_impl.dart 667                                   
_Future._propagateToListeners
  dart:async/future_impl.dart 477                                   
_Future._completeWithValue
  dart:async/future_impl.dart 528                                   
_Future._asyncComplete.<fn>
  dart:async/zone.dart 1150                                          _rootRun
  dart:async/zone.dart 1026                                         
_CustomZone.run
  dart:async/zone.dart 924                                          
_CustomZone.runGuarded
  dart:async/zone.dart 951                                          
_CustomZone.bindCallback.<fn>
  dart:async/schedule_microtask.dart 41                             
_microtaskLoop
  dart:async/schedule_microtask.dart 50                             
_startMicrotaskLoop
  dart:isolate-patch/timer_impl.dart 394                            
_Timer._runTimers
  dart:isolate-patch/timer_impl.dart 414                            
_Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 148                         
_RawReceivePortImpl._handleMessage

Repro with: python tools/test.py -aia32 --checked -mrelease -t60
pkg/analyzer/test/src/summary/resynthesize_ast_test

[scheglov, 2016-09-21 18:24:49]

https://codereview.chromium.org/2359953002 is out for review.