Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2359953002: Fix 'compareTypeParameterElements' to use TypeParameterElement, not Impl. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix 'compareTypeParameterElements' to use TypeParameterElement, not Impl. TBR This fixes the problem exposed by 5eea83396e0a008f269ec92d4b439be9bc00f01c. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e0150c45b16ed8f7878c340a32cd386f2ed275c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-21 18:24:28 UTC) #1
Paul Berry
lgtm
4 years, 3 months ago (2016-09-21 18:27:28 UTC) #2
scheglov
4 years, 3 months ago (2016-09-21 18:27:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0150c45b16ed8f7878c340a32cd386f2ed275c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698