Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: pkg/analyzer/lib/src/dart/element/member.dart

Issue 2351133004: Fix for out of scope type parameters in members. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/link.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/element/member.dart
diff --git a/pkg/analyzer/lib/src/dart/element/member.dart b/pkg/analyzer/lib/src/dart/element/member.dart
index 0ee331a54d38bd38207b91cef893e0a1afc89891..29b347fdc8b39d1a41f9776073f94c3002bcb828 100644
--- a/pkg/analyzer/lib/src/dart/element/member.dart
+++ b/pkg/analyzer/lib/src/dart/element/member.dart
@@ -114,9 +114,6 @@ class ConstructorMember extends ExecutableMember implements ConstructorElement {
List<DartType> parameterTypes = definingType.element.type.typeArguments;
FunctionType substitutedType =
baseType.substitute2(argumentTypes, parameterTypes);
- if (baseType == substitutedType) {
- return constructor;
- }
return new ConstructorMember(constructor, definingType, substitutedType);
}
}
@@ -408,9 +405,6 @@ class FunctionMember extends ExecutableMember implements FunctionElement {
TypeParameterTypeImpl.getTypes(definingType.typeParameters);
FunctionType substitutedType =
baseType.substitute2(argumentTypes, parameterTypes);
- if (baseType == substitutedType) {
- return method;
- }
return new MethodMember(method, definingType, substitutedType);
}
}
@@ -645,9 +639,6 @@ class MethodMember extends ExecutableMember implements MethodElement {
List<DartType> parameterTypes = definingType.element.type.typeArguments;
FunctionType substitutedType =
baseType.substitute2(argumentTypes, parameterTypes);
- if (baseType == substitutedType) {
- return method;
- }
return new MethodMember(method, definingType, substitutedType);
}
}
@@ -776,9 +767,6 @@ class ParameterMember extends VariableMember
TypeParameterTypeImpl.getTypes(definingType.typeParameters);
DartType substitutedType =
baseType.substitute2(argumentTypes, parameterTypes);
- if (baseType == substitutedType) {
- return parameter;
- }
return new ParameterMember(parameter, definingType, substitutedType);
}
}
@@ -990,9 +978,6 @@ class TypeParameterMember extends Member implements TypeParameterElement {
TypeParameterTypeImpl.getTypes(definingType.typeParameters);
DartType substitutedBound =
bound.substitute2(argumentTypes, parameterTypes);
- if (bound == substitutedBound) {
- return parameter;
- }
return new TypeParameterMember(parameter, definingType, substitutedBound);
}
}
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/link.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698