|
Oilpan: Remove guardRef and guardDeref from TreeScope.
This leads to a situation where Nodes and their TreeScope can die
at the same time and Nodes can no longer touch their document in
their destructors.
Instead we now have the following property:
A Node is either explicitly removed from its container and
|removedFrom| is called at that point, or the Node and the
TreeScope die at the same time.
This allows us to remove code from destructors that is only
there to clean up the TreeScope if the object was not
explicitly removed from the TreeScope. Other code in destructors
that go through the TreeScope to carry something out is
replaced by weak processing instead.
BUG= 357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172746
Total comments: 1
Total comments: 48
Total comments: 27
Total comments: 53
Total comments: 34
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+501 lines, -146 lines) |
Patch |
|
M |
Source/core/accessibility/AXObjectCache.h
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/accessibility/AXObjectCache.cpp
|
View
|
1
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/css/StyleSheetList.h
|
View
|
1
|
2 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/css/StyleSheetList.cpp
|
View
|
1
2
3
|
3 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/ContainerNode.cpp
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/Document.h
|
View
|
1
2
3
4
5
6
7
|
6 chunks |
+9 lines, -5 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/Document.cpp
|
View
|
1
2
3
4
5
6
7
|
9 chunks |
+71 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/DocumentMarkerController.h
|
View
|
1
2
3
4
5
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/DocumentMarkerController.cpp
|
View
|
1
2
3
|
1 chunk |
+13 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/DocumentTest.cpp
|
View
|
|
1 chunk |
+51 lines, -40 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/Element.cpp
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/EventHandlerRegistry.h
|
View
|
1
2
3
4
5
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/EventHandlerRegistry.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/Node.h
|
View
|
1
2
3
4
5
6
7
|
5 chunks |
+8 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/Node.cpp
|
View
|
1
2
3
4
5
6
7
|
8 chunks |
+27 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/ProcessingInstruction.cpp
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/StyleEngine.h
|
View
|
1
2
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/dom/StyleEngine.cpp
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/TreeScope.h
|
View
|
1
2
3
|
6 chunks |
+12 lines, -38 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/TreeScope.cpp
|
View
|
1
2
3
4
|
5 chunks |
+19 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/dom/TreeScopeAdopter.h
|
View
|
1
2
3
4
5
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/TreeScopeAdopter.cpp
|
View
|
|
3 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/shadow/ShadowRoot.h
|
View
|
1
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/dom/shadow/ShadowRoot.cpp
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+12 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/dom/shadow/ShadowRootRareData.h
|
View
|
1
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLCanvasElement.h
|
View
|
1
2
|
3 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLCanvasElement.cpp
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+8 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLFormControlElement.cpp
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLFormElement.cpp
|
View
|
1
2
3
4
5
6
|
2 chunks |
+8 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLInputElement.cpp
|
View
|
1
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLLinkElement.cpp
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLMediaElement.cpp
|
View
|
1
2
3
4
5
6
7
|
6 chunks |
+20 lines, -5 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLObjectElement.cpp
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLStyleElement.cpp
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/canvas/CanvasRenderingContext.h
|
View
|
|
3 chunks |
+11 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/html/canvas/CanvasRenderingContext2D.h
|
View
|
1
2
3
4
5
|
3 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
Source/core/html/canvas/CanvasRenderingContext2D.cpp
|
View
|
1
2
3
4
5
|
2 chunks |
+11 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/canvas/CanvasRenderingContext2D.idl
|
View
|
1
2
3
4
5
6
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/html/canvas/WebGLRenderingContext.h
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/html/canvas/WebGLRenderingContext.cpp
|
View
|
1
2
3
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/html/canvas/WebGLRenderingContext.idl
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/canvas/WebGLRenderingContextBase.h
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/html/canvas/WebGLRenderingContextBase.cpp
|
View
|
1
2
3
4
5
6
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp
|
View
|
1
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/imports/HTMLImportChild.h
|
View
|
1
2
3
4
5
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/imports/HTMLImportChild.cpp
|
View
|
1
|
2 chunks |
+8 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/shadow/DateTimeEditElement.cpp
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/html/shadow/TextControlInnerElements.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/page/DOMSelection.h
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/page/DOMSelection.cpp
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/page/FocusController.h
|
View
|
1
2
3
4
5
|
3 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/page/Page.h
|
View
|
1
2
3
4
5
6
|
4 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/page/Page.cpp
|
View
|
1
2
3
4
5
|
3 chunks |
+12 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/speech/SpeechInput.h
|
View
|
1
2
3
4
5
|
3 chunks |
+8 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/speech/SpeechInput.cpp
|
View
|
|
3 chunks |
+17 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/svg/SVGElement.cpp
|
View
|
1
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/svg/SVGFEImageElement.cpp
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/svg/SVGMPathElement.cpp
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/svg/SVGSVGElement.cpp
|
View
|
1
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/svg/SVGStyleElement.cpp
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/svg/SVGTextPathElement.cpp
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/svg/SVGUseElement.cpp
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/svg/animation/SVGSMILElement.cpp
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/GraphicsContext.cpp
|
View
|
1
2
3
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
Total messages: 23 (0 generated)
|