Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2511)

Unified Diff: Source/platform/graphics/GraphicsContext.cpp

Issue 235113002: Oilpan: Remove guardRef and guardDeref from TreeScope. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/animation/SVGSMILElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/GraphicsContext.cpp
diff --git a/Source/platform/graphics/GraphicsContext.cpp b/Source/platform/graphics/GraphicsContext.cpp
index fc49caf77fc95576d48cbd339b84c49380989064..fee5d78c74aba55a57ff52df563f264196b6af17 100644
--- a/Source/platform/graphics/GraphicsContext.cpp
+++ b/Source/platform/graphics/GraphicsContext.cpp
@@ -140,11 +140,18 @@ GraphicsContext::GraphicsContext(SkCanvas* canvas)
GraphicsContext::~GraphicsContext()
{
+#if !ENABLE(OILPAN)
+ // These asserts are only valid in debug mode and therefore do not seem
+ // useful. We cannot rely on them in any case. With Oilpan we cannot run
+ // the debug mode only code in CanvasRendingContext2D's destructor which
+ // touches other objects that are dead. Therefore, we disable these asserts
+ // with Oilpan and should probably consider just disabling them.
ASSERT(!m_paintStateIndex);
ASSERT(!m_paintState->saveCount());
ASSERT(!m_annotationCount);
ASSERT(!m_layerCount);
ASSERT(m_recordingStateStack.isEmpty());
+#endif
}
void GraphicsContext::save()
« no previous file with comments | « Source/core/svg/animation/SVGSMILElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698