chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 23506021: Require confirmation for writable directory access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 23506021: Require confirmation for writable directory access. (Closed) Base URL: http://git.chromium.org/chromium/src.git@directory-permission-hack

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/permissions/api_permission_set.cc ('K') | « chrome/common/extensions/permissions/api_permission_set_unittest.cc ('k') | chrome/common/extensions/permissions/permission_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index 9b9347e18174fc63e322330f3e2904306b1dbc0d..5a4df2d900b35f5f111202405a79c1372805dae9 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -283,6 +283,10 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

APIPermissionInfo::kFlagNone,

IDS_EXTENSION_PROMPT_WARNING_FILE_SYSTEM_WRITE,

PermissionMessage::kFileSystemWrite },

+ { APIPermission::kFileSystemWriteDirectory, "fileSystem.writeDirectory",

+ APIPermissionInfo::kFlagNone,

+ IDS_EXTENSION_PROMPT_WARNING_FILE_SYSTEM_WRITE_DIRECTORY,

+ PermissionMessage::kFileSystemWriteDirectory },

// Because warning messages for the "mediaGalleries" permission vary based

// on the permissions parameters, no message ID or message text is

// specified here.