Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4847)

Unified Diff: chrome/common/extensions/permissions/permission_set.cc

Issue 23506021: Require confirmation for writable directory access. (Closed) Base URL: http://git.chromium.org/chromium/src.git@directory-permission-hack
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set.cc
diff --git a/chrome/common/extensions/permissions/permission_set.cc b/chrome/common/extensions/permissions/permission_set.cc
index 2f6c9b7048b70adb7f9f3cdb4b557dfaa899fd81..e8b51dab4fdbdf0a23f86c133d3a9b190e570b56 100644
--- a/chrome/common/extensions/permissions/permission_set.cc
+++ b/chrome/common/extensions/permissions/permission_set.cc
@@ -482,21 +482,18 @@ std::set<PermissionMessage> PermissionSet::GetAPIPermissionMessages() const {
}
}
- // A special hack: If both kFileSystemDirectory and and kFileSystemWrite
- // would be displayed, instead show kFileSystemWriteDirectory.
+ // A special hack: If kFileSystemWriteDirectory would be displayed, hide
+ // kFileSystemDirectory and and kFileSystemWrite as the write directory
+ // message implies the other two.
// TODO(sammc): Remove this when http://crbug.com/282118 is fixed.
- std::set<PermissionMessage>::iterator read_directory_message = messages.find(
- PermissionMessage(PermissionMessage::kFileSystemDirectory, string16()));
- std::set<PermissionMessage>::iterator write_message = messages.find(
- PermissionMessage(PermissionMessage::kFileSystemWrite, string16()));
- if (read_directory_message != messages.end() &&
- write_message != messages.end()) {
- messages.erase(read_directory_message);
- messages.erase(write_message);
- messages.insert(PermissionMessage(
- PermissionMessage::kFileSystemWriteDirectory,
- l10n_util::GetStringUTF16(
- IDS_EXTENSION_PROMPT_WARNING_FILE_SYSTEM_WRITE_DIRECTORY)));
+ std::set<PermissionMessage>::iterator write_directory_message =
+ messages.find(PermissionMessage(
+ PermissionMessage::kFileSystemWriteDirectory, string16()));
+ if (write_directory_message != messages.end()) {
+ messages.erase(
+ PermissionMessage(PermissionMessage::kFileSystemWrite, string16()));
+ messages.erase(
+ PermissionMessage(PermissionMessage::kFileSystemDirectory, string16()));
}
return messages;
}

Powered by Google App Engine
This is Rietveld 408576698