Require confirmation for writable directory access.

chrome/common/extensions/permissions/api_permission_set.cc

Index: chrome/common/extensions/permissions/api_permission_set.cc
diff --git a/chrome/common/extensions/permissions/api_permission_set.cc b/chrome/common/extensions/permissions/api_permission_set.cc
index 4c24ab551cc1342ceeefc2a566af2ddcedf53c8e..d8098070379fd7944f7b49711f9d7bf0e533d925 100644
--- a/chrome/common/extensions/permissions/api_permission_set.cc
+++ b/chrome/common/extensions/permissions/api_permission_set.cc
@@ -5,6 +5,7 @@
 #include "chrome/common/extensions/permissions/api_permission_set.h"
 
 #include "base/logging.h"
+#include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
@@ -335,4 +336,13 @@ bool APIPermissionSet::ParseFromJSON(
   return true;
 }
 
+void APIPermissionSet::AddImpliedPermissions() {
+  // The fileSystem.write and fileSystem.directory permissions imply
+  // fileSystem.writeDirectory.
+  if (ContainsKey(map_, APIPermission::kFileSystemWrite) &&
+      ContainsKey(map_, APIPermission::kFileSystemDirectory)) {
+    insert(APIPermission::kFileSystemWriteDirectory);

[not at google - send to devlin, 2013/09/03 17:07:04]

Ugh so busted. But I agree that there doesn't seem to be a better way to do this
in our current permission warning infrastructure.

But please file a specific bug to remove this + the similar code in
permission_set.cc and set that general permission bug as blocking it. This code
is going to block the extensions refactor.

[Sam McNally, 2013/09/04 00:21:30]

Done.

+  }
+}
+
 }  // namespace extensions