Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: public/web/WebView.h

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add WebViewHelper for unittests. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« public/web/WebFrame.h ('K') | « public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebView.h
diff --git a/public/web/WebView.h b/public/web/WebView.h
index eaaed134963ba2bb3d4b7c5af6f40da934d8d2ba..a0dfa51d30e55b7b46f267ab0f04ae860e22c6ee 100644
--- a/public/web/WebView.h
+++ b/public/web/WebView.h
@@ -96,11 +96,9 @@ public:
// After creating a WebView, you should immediately call this method.
// You can optionally modify the settings before calling this method.
- // The WebFrameClient will receive events for the main frame and any
- // child frames. It is valid to pass a null WebFrameClient pointer.
- virtual void initializeMainFrame(WebFrameClient*) = 0;
-
- virtual void initializeHelperPluginFrame(WebFrameClient*) = 0;
+ // This WebFrame will receive events for the main frame and must not
+ // be null.
+ virtual void initializeMainFrame(WebFrame*) = 0;
darin (slow to review) 2013/09/13 04:02:47 Perhaps this method should be renamed to setMainFr
awong 2013/09/18 22:04:47 I added a second method. This is necessary to fac
// Initializes the various client interfaces.
virtual void setAutofillClient(WebAutofillClient*) = 0;
« public/web/WebFrame.h ('K') | « public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698