Make the embedder responsible for creating the WebFrame

public/web/WebView.h

 /*
  * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 78 matching lines @@
 
     // Initialization ------------------------------------------------------
 
     // Creates a WebView that is NOT yet initialized.  You will need to
     // call initializeMainFrame to finish the initialization.  It is valid
     // to pass null client pointers.
     WEBKIT_EXPORT static WebView* create(WebViewClient*);
 
     // After creating a WebView, you should immediately call this method.
     // You can optionally modify the settings before calling this method.
-    // The WebFrameClient will receive events for the main frame and any
-    // child frames.  It is valid to pass a null WebFrameClient pointer.
-    virtual void initializeMainFrame(WebFrameClient*) = 0;
-
-    virtual void initializeHelperPluginFrame(WebFrameClient*) = 0;
+    // This WebFrame will receive events for the main frame and must not
+    // be null.
+    virtual void initializeMainFrame(WebFrame*) = 0;

[darin (slow to review), 2013/09/13 04:02:47]

Perhaps this method should be renamed to setMainFrame? The comments should
probably be updated accordingly too.

[awong, 2013/09/18 22:04:47]

I added a second method.  This is necessary to facilitate landing.  I'm unsure
what to update on the comment though. It seems accurate to me.

 
     // Initializes the various client interfaces.
     virtual void setAutofillClient(WebAutofillClient*) = 0;
     virtual void setDevToolsAgentClient(WebDevToolsAgentClient*) = 0;
     virtual void setPermissionClient(WebPermissionClient*) = 0;
     virtual void setPrerendererClient(WebPrerendererClient*) = 0;
     virtual void setSpellCheckClient(WebSpellCheckClient*) = 0;
     virtual void setValidationMessageClient(WebValidationMessageClient*) = 0;
     virtual void setPasswordGeneratorClient(WebPasswordGeneratorClient*) = 0;
 
@@ skipping 404 matching lines @@
 
     // Testing functionality for TestRunner ---------------------------------
 
 protected:
     ~WebView() {}
 };
 
 } // namespace WebKit
 
 #endif