Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: public/web/WebFrameClient.h

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add WebViewHelper for unittests. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebFrameClient.h
diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h
index 5e21a0423a37b028824bc5d4a2efeed023590e3b..e536748a753285d40bf316a2e7e3642c4aeca2db 100644
--- a/public/web/WebFrameClient.h
+++ b/public/web/WebFrameClient.h
@@ -107,9 +107,10 @@ public:
virtual void didAccessInitialDocument(WebFrame*) { }
// A child frame was created in this frame. This is called when the frame
- // is created and initialized.
- virtual void didCreateFrame(WebFrame* parent, WebFrame* child) { }
-
+ // is created and initialized. Takes the name of the new frame, the parent
+ // frame and returns a new WebFrame. The WebFrame is valid until
+ // frameDetached() is called on it.
+ virtual WebFrame* createChildFrame(WebFrame* parent, const WebString& frameName) { return 0; }
// This frame set its opener to null, disowning it.
// See http://html.spec.whatwg.org/#dom-opener.
virtual void didDisownOpener(WebFrame*) { }

Powered by Google App Engine
This is Rietveld 408576698