Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add WebViewHelper for unittests. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/WebFrameImpl.h » ('j') | Source/web/WebFrameImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FrameLoader.cpp
diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp
index 174e8065f34db41daf14c6045a11997b8ed12e54..ae373d3fc6772e402c896a894636fd4479b40a46 100644
--- a/Source/core/loader/FrameLoader.cpp
+++ b/Source/core/loader/FrameLoader.cpp
@@ -1155,6 +1155,18 @@ void FrameLoader::detachFromParent()
m_progressTracker.clear();
+ //
+ //
+ //
+ // Note...the problem is mainframe ownership is the embedder and not the
darin (slow to review) 2013/09/13 04:02:47 nit: this comment could use some word-smithing.
+ // FrameLoader. This is borked. What we want is the mainframe to get be
+ // adoptRefed() in the initalizeAsMainFrame() call somewhere. Weird, but
+ // it makes it consistent with child frames in that the embedder holds
+ // nothing. Either that, or the embedder should drop the ref afterwards.
+ // All this is odd.
+ //
+ //
+
if (Frame* parent = m_frame->tree()->parent()) {
parent->loader()->closeAndRemoveChild(m_frame);
parent->loader()->scheduleCheckCompleted();
« no previous file with comments | « no previous file | Source/web/WebFrameImpl.h » ('j') | Source/web/WebFrameImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698