Index: Source/core/loader/FrameLoader.cpp |
diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp |
index 174e8065f34db41daf14c6045a11997b8ed12e54..ae373d3fc6772e402c896a894636fd4479b40a46 100644 |
--- a/Source/core/loader/FrameLoader.cpp |
+++ b/Source/core/loader/FrameLoader.cpp |
@@ -1155,6 +1155,18 @@ void FrameLoader::detachFromParent() |
m_progressTracker.clear(); |
+ // |
+ // |
+ // |
+ // Note...the problem is mainframe ownership is the embedder and not the |
darin (slow to review)
2013/09/13 04:02:47
nit: this comment could use some word-smithing.
|
+ // FrameLoader. This is borked. What we want is the mainframe to get be |
+ // adoptRefed() in the initalizeAsMainFrame() call somewhere. Weird, but |
+ // it makes it consistent with child frames in that the embedder holds |
+ // nothing. Either that, or the embedder should drop the ref afterwards. |
+ // All this is odd. |
+ // |
+ // |
+ |
if (Frame* parent = m_frame->tree()->parent()) { |
parent->loader()->closeAndRemoveChild(m_frame); |
parent->loader()->scheduleCheckCompleted(); |