Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: Source/web/WebFrameImpl.h

Issue 23506013: Make the embedder responsible for creating the WebFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add WebViewHelper for unittests. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebFrameImpl.h
diff --git a/Source/web/WebFrameImpl.h b/Source/web/WebFrameImpl.h
index 104f8497aa3281da92443b7c2d7f0a33399a3d2f..ac579adb4ca66638fe818029f21086b4e91c5cdf 100644
--- a/Source/web/WebFrameImpl.h
+++ b/Source/web/WebFrameImpl.h
@@ -76,6 +76,7 @@ class WebFrameImpl
, public WebCore::FrameDestructionObserver {
public:
// WebFrame methods:
+ virtual void close();
virtual WebString uniqueName() const;
virtual WebString assignedName() const;
virtual void setName(const WebString&);
@@ -239,7 +240,7 @@ public:
// WebCore::FrameDestructionObserver methods.
virtual void willDetachPage();
- static PassRefPtr<WebFrameImpl> create(WebFrameClient* client);
+ static WebFrameImpl* create(WebFrameClient*, long long identifier);
virtual ~WebFrameImpl();
// Called by the WebViewImpl to initialize the main frame for the page.
@@ -328,7 +329,7 @@ private:
InvalidateAll // Both content area and the scrollbar.
};
- explicit WebFrameImpl(WebFrameClient*);
+ explicit WebFrameImpl(WebFrameClient*, long long frame_identifier);
// Sets the local WebCore frame and registers destruction observers.
void setWebCoreFrame(WebCore::Frame*);

Powered by Google App Engine
This is Rietveld 408576698