Make the embedder responsible for creating the WebFrame

Source/core/loader/FrameLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008 Alp Toker <alp@atoker.com>
  * Copyright (C) Research In Motion Limited 2009. All rights reserved.
  * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ skipping 1137 matching lines @@
 
     InspectorInstrumentation::frameDetachedFromParent(m_frame);
 
     if (m_documentLoader)
         m_documentLoader->detachFromFrame();
     m_documentLoader = 0;
     m_client->detachedFromParent();
 
     m_progressTracker.clear();
 
+    //
+    //
+    //
+    // Note...the problem is mainframe ownership is the embedder and not the

[darin (slow to review), 2013/09/13 04:02:47]

nit: this comment could use some word-smithing.

+    // FrameLoader. This is borked.  What we want is the mainframe to get be
+    // adoptRefed() in the initalizeAsMainFrame() call somewhere. Weird, but
+    // it makes it consistent with child frames in that the embedder holds
+    // nothing. Either that, or the embedder should drop the ref afterwards.
+    // All this is odd.
+    //
+    //
+
     if (Frame* parent = m_frame->tree()->parent()) {
         parent->loader()->closeAndRemoveChild(m_frame);
         parent->loader()->scheduleCheckCompleted();
     } else {
         m_frame->setView(0);
         m_frame->willDetachPage();
         m_frame->detachFromPage();
     }
 }
 
@@ skipping 438 matching lines @@
 {
     SandboxFlags flags = m_forcedSandboxFlags;
     if (Frame* parentFrame = m_frame->tree()->parent())
         flags |= parentFrame->document()->sandboxFlags();
     if (HTMLFrameOwnerElement* ownerElement = m_frame->ownerElement())
         flags |= ownerElement->sandboxFlags();
     return flags;
 }
 
 } // namespace WebCore