Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issue 23503070: Revert 223610 "Set the printer info in crash reports using the c..." (Closed)

Created:
7 years, 3 months ago by Finnur
Modified:
7 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 223610 "Set the printer info in crash reports using the c..." Reverting due to buffer overflow reported on the Linux mem bot. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/15489 > Set the printer info in crash reports using the crash key logging system. > > BUG=77656 > R=jochen@chromium.org > > Review URL: https://codereview.chromium.org/23604061 TBR=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -68 lines) Patch
M trunk/src/chrome/app/breakpad_linux.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M trunk/src/chrome/app/breakpad_win.cc View 3 chunks +26 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/printing/print_system_task_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/child_process_logging.h View 4 chunks +27 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/child_process_logging_mac.mm View 2 chunks +15 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/child_process_logging_posix.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/child_process_logging_win.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/crash_keys.h View 2 chunks +0 lines, -16 lines 0 comments Download
M trunk/src/chrome/common/crash_keys.cc View 4 chunks +0 lines, -36 lines 0 comments Download
M trunk/src/chrome/service/cloud_print/print_system_cups.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/chrome/service/cloud_print/print_system_win.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/chrome/utility/chrome_content_utility_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
7 years, 3 months ago (2013-09-17 14:44:31 UTC) #1
Finnur
7 years, 3 months ago (2013-09-17 14:44:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r223613.

Powered by Google App Engine
This is Rietveld 408576698