Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1934)

Unified Diff: trunk/src/chrome/service/cloud_print/print_system_cups.cc

Issue 23503070: Revert 223610 "Set the printer info in crash reports using the c..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/common/crash_keys.cc ('k') | trunk/src/chrome/service/cloud_print/print_system_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/service/cloud_print/print_system_cups.cc
===================================================================
--- trunk/src/chrome/service/cloud_print/print_system_cups.cc (revision 223612)
+++ trunk/src/chrome/service/cloud_print/print_system_cups.cc (working copy)
@@ -25,8 +25,8 @@
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
+#include "chrome/common/child_process_logging.h"
#include "chrome/common/cloud_print/cloud_print_constants.h"
-#include "chrome/common/crash_keys.h"
#include "chrome/service/cloud_print/cloud_print_helpers.h"
#include "grit/generated_resources.h"
#include "printing/backend/cups_helper.h"
@@ -264,7 +264,7 @@
PrintSystem::PrinterWatcher::Delegate* delegate) OVERRIDE{
scoped_refptr<printing::PrintBackend> print_backend(
printing::PrintBackend::CreateInstance(NULL));
- crash_keys::ScopedPrinterInfo crash_key(
+ child_process_logging::ScopedPrinterInfoSetter prn_info(
print_backend->GetPrinterDriverInfo(printer_name_));
if (delegate_ != NULL)
StopWatching();
@@ -595,7 +595,7 @@
}
// TODO(gene): Retry multiple times in case of error.
- crash_keys::ScopedPrinterInfo crash_key(
+ child_process_logging::ScopedPrinterInfoSetter prn_info(
server_info->backend->GetPrinterDriverInfo(short_printer_name));
if (!server_info->backend->GetPrinterCapsAndDefaults(short_printer_name,
printer_info) ) {
@@ -618,7 +618,7 @@
if (!server_info)
return false;
- crash_keys::ScopedPrinterInfo crash_key(
+ child_process_logging::ScopedPrinterInfoSetter prn_info(
server_info->backend->GetPrinterDriverInfo(short_printer_name));
cups_job_t* jobs = NULL;
int num_jobs = GetJobs(&jobs, server_info->url, cups_encryption_,
@@ -778,7 +778,7 @@
if (!server_info)
return false;
- crash_keys::ScopedPrinterInfo crash_key(
+ child_process_logging::ScopedPrinterInfoSetter prn_info(
server_info->backend->GetPrinterDriverInfo(printer_name));
// We need to store options as char* string for the duration of the
« no previous file with comments | « trunk/src/chrome/common/crash_keys.cc ('k') | trunk/src/chrome/service/cloud_print/print_system_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698