Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: trunk/src/chrome/common/crash_keys.cc

Issue 23503070: Revert 223610 "Set the printer info in crash reports using the c..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/common/crash_keys.h ('k') | trunk/src/chrome/service/cloud_print/print_system_cups.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/common/crash_keys.cc
===================================================================
--- trunk/src/chrome/common/crash_keys.cc (revision 223612)
+++ trunk/src/chrome/common/crash_keys.cc (working copy)
@@ -6,7 +6,6 @@
#include "base/format_macros.h"
#include "base/logging.h"
-#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
@@ -72,8 +71,6 @@
const char kGPUGLVersion[] = "gpu-glver";
#endif
-const char kPrinterInfo[] = "prn-info-%" PRIuS;
-
#if defined(OS_MACOSX)
namespace mac {
@@ -163,20 +160,6 @@
}
}
- // Register the printer info.
- {
- static char formatted_keys[kPrinterInfoCount][sizeof(kPrinterInfo) + 1] =
- {{ 0 }};
- const size_t formatted_key_len = sizeof(formatted_keys[0]);
- for (size_t i = 1; i <= kPrinterInfoCount; ++i) {
- int n = base::snprintf(
- formatted_keys[i], formatted_key_len, kPrinterInfo, i);
- DCHECK_GT(n, 0);
- base::debug::CrashKey crash_key = { formatted_keys[i], kSmallSize };
- keys.push_back(crash_key);
- }
- }
-
return base::debug::InitCrashKeys(&keys.at(0), keys.size(),
kSingleChunkLength);
}
@@ -197,23 +180,4 @@
}
}
-ScopedPrinterInfo::ScopedPrinterInfo(const base::StringPiece& data) {
- std::vector<std::string> info;
- base::SplitString(data.as_string(), ';', &info);
- for (size_t i = 1; i <= kPrinterInfoCount; ++i) {
- std::string key = base::StringPrintf(kPrinterInfo, i);
- std::string value;
- if (i < info.size())
- value = info[i];
- base::debug::SetCrashKeyValue(key, value);
- }
-}
-
-ScopedPrinterInfo::~ScopedPrinterInfo() {
- for (size_t i = 1; i <= kPrinterInfoCount; ++i) {
- std::string key = base::StringPrintf(kPrinterInfo, i);
- base::debug::ClearCrashKey(key);
- }
-}
-
} // namespace crash_keys
« no previous file with comments | « trunk/src/chrome/common/crash_keys.h ('k') | trunk/src/chrome/service/cloud_print/print_system_cups.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698