Make CPDF_IndirectObjectHolder use unique_ptr to objects

Make CPDF_IndirectObjectHolder use unique_ptr to objects

The objects it is given are owned by it and are simply
deleted without regard to Release() used by others.

Committed: https://pdfium.googlesource.com/pdfium/+/c8544d634a1993e2592e41458be215fcd0956031

[Tom Sepez, 2016-09-19 20:02:38]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 20:02:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-19 20:06:03]

Description was changed from

==========
Make CPDF_IndirectObjectHolder use unique_ptr to objects
==========

to

==========
Make CPDF_IndirectObjectHolder use unique_ptr to objects

The objects it is given are owned by it and are simply
deleted without regard to Release() used by others.
==========

[Tom Sepez, 2016-09-19 20:06:03]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-19 20:08:02]

https://codereview.chromium.org/2350263002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/cpdf_object.h (right):

https://codereview.chromium.org/2350263002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/cpdf_object.h:96: friend struct
std::default_delete<CPDF_Object>;
Note: we have this in several places in chromium/src/base etc. as a precedent.

[dsinclair, 2016-09-19 20:13:47]

lgtm w/ possible followup nits

https://codereview.chromium.org/2350263002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp (right):

https://codereview.chromium.org/2350263002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp:45: uint32_t
CPDF_IndirectObjectHolder::AddIndirectObject(CPDF_Object* pObj) {
Make this a std::unique_ptr?

https://codereview.chromium.org/2350263002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp:57: CPDF_Object* pObj)
{
Can this be a std::unique_ptr?

https://codereview.chromium.org/2350263002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/cpdf_object.h (right):

https://codereview.chromium.org/2350263002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/cpdf_object.h:96: friend struct
std::default_delete<CPDF_Object>;
On 2016/09/19 20:08:02, Tom Sepez wrote:
> Note: we have this in several places in chromium/src/base etc. as a precedent.


That's cool, never seen that before.

[Tom Sepez, 2016-09-19 20:36:35]

https://codereview.chromium.org/2350263002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp (right):

https://codereview.chromium.org/2350263002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp:45: uint32_t
CPDF_IndirectObjectHolder::AddIndirectObject(CPDF_Object* pObj) {
On 2016/09/19 20:13:47, dsinclair wrote:
> Make this a std::unique_ptr?
Tricky.  It might not take ownership if the object already has a number.  One of
the things that makes straightening this out so hard.

https://codereview.chromium.org/2350263002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp:57: CPDF_Object* pObj)
{
On 2016/09/19 20:13:47, dsinclair wrote:
> Can this be a std::unique_ptr?

Ditto.  These all have "maybe take ownership" semantics. Ick.

[Tom Sepez, 2016-09-19 20:37:10]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:37:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:05:07]

Description was changed from

==========
Make CPDF_IndirectObjectHolder use unique_ptr to objects

The objects it is given are owned by it and are simply
deleted without regard to Release() used by others.
==========

to

==========
Make CPDF_IndirectObjectHolder use unique_ptr to objects

The objects it is given are owned by it and are simply
deleted without regard to Release() used by others.

Committed:
https://pdfium.googlesource.com/pdfium/+/c8544d634a1993e2592e41458be215fcd095...
==========

[commit-bot: I haz the power, 2016-09-19 21:05:08]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/c8544d634a1993e2592e41458be215fcd095...