core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp - Issue 2350263002: Make CPDF_IndirectObjectHolder use unique_ptr to objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

Issue 2350263002: Make CPDF_IndirectObjectHolder use unique_ptr to objects (Closed)

Patch Set: Leave my name alone please Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

diff --git a/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

index cab99ecf7f5bdefc2e7f502a7b58a098a47cc833..36f622664d78042b09f70d11d86c9f99b494e5f6 100644

--- a/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

+++ b/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

@@ -1365,7 +1365,7 @@ void CPDF_Creator::InitNewObjNumOffsets() {

FX_BOOL bNoOriginal = (m_dwFlags & FPDFCREATE_NO_ORIGINAL) != 0;

for (const auto& pair : *m_pDocument) {

const uint32_t objnum = pair.first;

- const CPDF_Object* pObj = pair.second;

+ const CPDF_Object* pObj = pair.second.get();

if (bIncremental || pObj->GetObjNum() == CPDF_Object::kInvalidObjNum)

continue;

if (m_pParser && m_pParser->IsValidObjectNumber(objnum) &&