Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: core/fpdfapi/fpdf_parser/include/cpdf_object.h

Issue 2350263002: Make CPDF_IndirectObjectHolder use unique_ptr to objects (Closed)
Patch Set: Leave my name alone please Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_OBJECT_H_ 7 #ifndef CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_OBJECT_H_
8 #define CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_OBJECT_H_ 8 #define CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_OBJECT_H_
9 9
10 #include <memory>
10 #include <set> 11 #include <set>
11 12
12 #include "core/fxcrt/include/fx_string.h" 13 #include "core/fxcrt/include/fx_string.h"
13 #include "core/fxcrt/include/fx_system.h" 14 #include "core/fxcrt/include/fx_system.h"
14 15
15 class CPDF_Array; 16 class CPDF_Array;
16 class CPDF_Boolean; 17 class CPDF_Boolean;
17 class CPDF_Dictionary; 18 class CPDF_Dictionary;
18 class CPDF_Name; 19 class CPDF_Name;
19 class CPDF_Null; 20 class CPDF_Null;
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 virtual const CPDF_String* AsString() const; 86 virtual const CPDF_String* AsString() const;
86 87
87 protected: 88 protected:
88 friend class CPDF_Array; 89 friend class CPDF_Array;
89 friend class CPDF_Dictionary; 90 friend class CPDF_Dictionary;
90 friend class CPDF_Document; 91 friend class CPDF_Document;
91 friend class CPDF_IndirectObjectHolder; 92 friend class CPDF_IndirectObjectHolder;
92 friend class CPDF_Parser; 93 friend class CPDF_Parser;
93 friend class CPDF_Reference; 94 friend class CPDF_Reference;
94 friend class CPDF_Stream; 95 friend class CPDF_Stream;
96 friend struct std::default_delete<CPDF_Object>;
Tom Sepez 2016/09/19 20:08:02 Note: we have this in several places in chromium/s
dsinclair 2016/09/19 20:13:47 That's cool, never seen that before.
95 97
96 CPDF_Object() : m_ObjNum(0), m_GenNum(0) {} 98 CPDF_Object() : m_ObjNum(0), m_GenNum(0) {}
97 virtual ~CPDF_Object(); 99 virtual ~CPDF_Object();
98 100
99 CPDF_Object* CloneObjectNonCyclic(bool bDirect) const; 101 CPDF_Object* CloneObjectNonCyclic(bool bDirect) const;
100 102
101 // Create a deep copy of the object with the option to either 103 // Create a deep copy of the object with the option to either
102 // copy a reference object or directly copy the object it refers to 104 // copy a reference object or directly copy the object it refers to
103 // when |bDirect| is true. 105 // when |bDirect| is true.
104 // Also check cyclic reference against |pVisited|, no copy if it is found. 106 // Also check cyclic reference against |pVisited|, no copy if it is found.
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 174
173 inline CPDF_Stream* ToStream(CPDF_Object* obj) { 175 inline CPDF_Stream* ToStream(CPDF_Object* obj) {
174 return obj ? obj->AsStream() : nullptr; 176 return obj ? obj->AsStream() : nullptr;
175 } 177 }
176 178
177 inline const CPDF_Stream* ToStream(const CPDF_Object* obj) { 179 inline const CPDF_Stream* ToStream(const CPDF_Object* obj) {
178 return obj ? obj->AsStream() : nullptr; 180 return obj ? obj->AsStream() : nullptr;
179 } 181 }
180 182
181 #endif // CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_OBJECT_H_ 183 #endif // CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_OBJECT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698