Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2350173005: QUIC enable server push by default. Guarded by FLAGS_quic_enable_server_push_by_default. (Closed)

Created:
4 years, 3 months ago by Jana
Modified:
4 years, 3 months ago
Reviewers:
Buck, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC enable server push by default. Guarded by FLAGS_quic_enable_server_push_by_default. Enable server push by default for QUIC versions 35 and higher. Also adds support so that push can be disabled using HTTP/2 SETTINGS_ENABLE_PUSH. Merge internal change: 133188946 R=ckrasic@chromium.org, rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -20 lines) Patch
M net/quic/core/quic_flags_list.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 2 chunks +30 lines, -5 lines 0 comments Download
M net/quic/core/quic_server_session_base.h View 3 chunks +0 lines, -8 lines 0 comments Download
M net/quic/core/quic_server_session_base.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 2 chunks +10 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 2 chunks +7 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (4 generated)
Jana
4 years, 3 months ago (2016-09-19 23:37:11 UTC) #1
Ryan Hamilton
lgtm
4 years, 3 months ago (2016-09-20 17:23:24 UTC) #6
Buck
4 years, 3 months ago (2016-09-20 17:33:48 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698