Use refcounted ownership for ValidateClientHelloResultCallback::Result

Use refcounted ownership for ValidateClientHelloResultCallback::Result

This CL switches ValidateClientHelloResultCallback::Result to use
refcounted ownership semantics.  This has no effect in current code, but
will be useful in solving some object lifetime issues as more codepaths
are asynchronized.

Change to refcounted ownership for
ValidateClientHelloResultCallback::Result.  No functional change beyond
this intended, not flag-protected.

Merge internal change: 133129391

R=rch@chromium.org
BUG=

[Jana, 2016-09-19 22:19:16]

The CQ bit was checked by jri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:19:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-09-19 22:35:49]

lgtm, though I do have a question about std::move()

https://codereview.chromium.org/2353763002/diff/1/net/quic/core/crypto/crypto...
File net/quic/core/crypto/crypto_server_test.cc (right):

https://codereview.chromium.org/2353763002/diff/1/net/quic/core/crypto/crypto...
net/quic/core/crypto/crypto_server_test.cc:216:
test_->ProcessValidationResult(std::move(result), should_succeed_,
do we need std::move on a scoped_refptr? (Does the original CL do this?

https://codereview.chromium.org/2353763002/diff/1/net/quic/core/crypto/quic_c...
File net/quic/core/crypto/quic_crypto_server_config.cc (right):

https://codereview.chromium.org/2353763002/diff/1/net/quic/core/crypto/quic_c...
net/quic/core/crypto/quic_crypto_server_config.cc:89: :
result_(std::move(result)), done_cb_(done_cb) {}
ditto.

[commit-bot: I haz the power, 2016-09-20 01:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:27:09]

Dry run: This issue passed the CQ dry run.

[Jana, 2016-09-20 21:28:52]

https://codereview.chromium.org/2353763002/diff/1/net/quic/core/crypto/crypto...
File net/quic/core/crypto/crypto_server_test.cc (right):

https://codereview.chromium.org/2353763002/diff/1/net/quic/core/crypto/crypto...
net/quic/core/crypto/crypto_server_test.cc:216:
test_->ProcessValidationResult(std::move(result), should_succeed_,
On 2016/09/19 22:35:48, Ryan Hamilton wrote:
> do we need std::move on a scoped_refptr? (Does the original CL do this?

Yeah, I wondered about this too -- I didn't realize until I saw it in this CL
that you could do a move on scoped_refptrs. It's in the original CL. I don't
understand why this would be needed though... it seems like a relatively
non-essential optimization.

https://codereview.chromium.org/2353763002/diff/1/net/quic/core/crypto/quic_c...
File net/quic/core/crypto/quic_crypto_server_config.cc (right):

https://codereview.chromium.org/2353763002/diff/1/net/quic/core/crypto/quic_c...
net/quic/core/crypto/quic_crypto_server_config.cc:89: :
result_(std::move(result)), done_cb_(done_cb) {}
On 2016/09/19 22:35:49, Ryan Hamilton wrote:
> ditto.

Acknowledged.

[Ryan Hamilton, 2016-09-20 22:26:38]

lgtm