Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2353063002: Only inform QUIC's SentPacketManager of packets that are actually sent, not those that failed to be… (Closed)

Created:
4 years, 3 months ago by Jana
Modified:
4 years, 3 months ago
Reviewers:
ianswett, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only inform QUIC's SentPacketManager of packets that are actually sent, not those that failed to be sent. Protected by FLAGS_quic_only_track_sent_packets. Merge internal change: 133209233 R=ianswett@chromium.org, rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -25 lines) Patch
M net/quic/core/quic_connection.cc View 3 chunks +54 lines, -21 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (4 generated)
Jana
4 years, 3 months ago (2016-09-20 16:55:27 UTC) #1
Ryan Hamilton
4 years, 3 months ago (2016-09-20 17:24:01 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698