Add request-level caching for privileged queries.

dashboard/dashboard/update_test_suites_test.py

Index: dashboard/dashboard/update_test_suites_test.py
diff --git a/dashboard/dashboard/update_test_suites_test.py b/dashboard/dashboard/update_test_suites_test.py
index 62181b5eed28f680969b5d50bb098fc0d3f15716..32ebfe54168dfae002e54aced299704398b2445e 100644
--- a/dashboard/dashboard/update_test_suites_test.py
+++ b/dashboard/dashboard/update_test_suites_test.py
@@ -28,6 +28,7 @@ class ListTestSuitesTest(testing_common.TestCase):
     datastore_hooks.InstallHooks()
     testing_common.SetIsInternalUser('internal@chromium.org', True)
     self.UnsetCurrentUser()
+    self.PatchDatastoreHooksRequest()
 
   def testFetchCachedTestSuites_NotEmpty(self):
     # If the cache is set, then whatever's there is returned.
@@ -67,6 +68,8 @@ class ListTestSuitesTest(testing_common.TestCase):
         })
 
   def testPost_ForcesCacheUpdate(self):
+    request = webapp2.get_request()
+    request.registry['privileged_cached'] = False

[sullivan, 2016/09/19 21:40:27]

This seems to have been the only unit test affected by switching the default
from False->True if there is no request object (the direct calls to
update_test_suites.FetchCachedTestSuites() have different behavior now). It was
expecting *not* to be privileged, so set that.

     key = update_test_suites._NamespaceKey(
         update_test_suites._LIST_SUITES_CACHE_KEY)
     stored_object.Set(key, {'foo': 'bar'})
@@ -95,6 +98,7 @@ class ListTestSuitesTest(testing_common.TestCase):
             },
         },
         update_test_suites.FetchCachedTestSuites())
+    del request.registry['privileged_cached']

[benjhayden, 2016/09/19 22:14:53]

Is this needed?

[sullivan, 2016/09/20 02:19:32]

Done.

 
   def testPost_InternalOnly(self):
     self.SetCurrentUser('internal@chromium.org')