Add request-level caching for privileged queries.

dashboard/dashboard/testing_common.py

Index: dashboard/dashboard/testing_common.py
diff --git a/dashboard/dashboard/testing_common.py b/dashboard/dashboard/testing_common.py
index ae094650856989007241d2357aad3e0db5405be7..f67f5058b9904a1bac8f8ca7c079ff8efef4eb6a 100644
--- a/dashboard/dashboard/testing_common.py
+++ b/dashboard/dashboard/testing_common.py
@@ -11,6 +11,7 @@ import os
 import re
 import unittest
 import urllib
+import webapp2
 
 from google.appengine.api import users
 from google.appengine.ext import deferred
@@ -89,6 +90,13 @@ class TestCase(unittest.TestCase):
 
   def SetCurrentUser(self, email, user_id='123456', is_admin=False):
     """Sets the user in the environment in the current testbed."""
+    try:
+      request = webapp2.get_request()
+      if 'privileged_cached' in request.registry:
+        del request.registry['privileged_cached']
+    except AssertionError:
+      # webapp2.get_request() not patched for this test.
+      pass

[sullivan, 2016/09/19 21:40:27]

This is now needed because a lot of unit tests call SetCurrentUser to change
internal_only in unit tests. In real requests, request.registry gets reset in
separate requests, but if a single unit test makes multiple requests, the ones
in the same unit test keep the cached request.registry. So reset it when
resetting the user.

     self.testbed.setup_env(
         user_is_admin=('1' if is_admin else '0'),
         user_email=email,