Add request-level caching for privileged queries.

dashboard/dashboard/update_test_suites_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 
 import webapp2
 import webtest
 
 from google.appengine.ext import ndb
@@ skipping 10 matching lines @@
 
   def setUp(self):
     super(ListTestSuitesTest, self).setUp()
     app = webapp2.WSGIApplication(
         [('/update_test_suites',
           update_test_suites.UpdateTestSuitesHandler)])
     self.testapp = webtest.TestApp(app)
     datastore_hooks.InstallHooks()
     testing_common.SetIsInternalUser('internal@chromium.org', True)
     self.UnsetCurrentUser()
+    self.PatchDatastoreHooksRequest()
 
   def testFetchCachedTestSuites_NotEmpty(self):
     # If the cache is set, then whatever's there is returned.
     key = update_test_suites._NamespaceKey(
         update_test_suites._LIST_SUITES_CACHE_KEY)
     stored_object.Set(key, {'foo': 'bar'})
     self.assertEqual(
         {'foo': 'bar'},
         update_test_suites.FetchCachedTestSuites())
 
@@ skipping 19 matching lines @@
                         'deeply': {
                             'subtest': {}
                         }
                     },
                     'very_very': {}
                 }
             },
         })
 
   def testPost_ForcesCacheUpdate(self):
+    request = webapp2.get_request()
+    request.registry['privileged_cached'] = False

[sullivan, 2016/09/19 21:40:27]

This seems to have been the only unit test affected by switching the default
from False->True if there is no request object (the direct calls to
update_test_suites.FetchCachedTestSuites() have different behavior now). It was
expecting *not* to be privileged, so set that.

     key = update_test_suites._NamespaceKey(
         update_test_suites._LIST_SUITES_CACHE_KEY)
     stored_object.Set(key, {'foo': 'bar'})
     self.assertEqual(
         {'foo': 'bar'},
         update_test_suites.FetchCachedTestSuites())
     self._AddSampleData()
     # Because there is something cached, the cache is
     # not automatically updated when new data is added.
     self.assertEqual(
         {'foo': 'bar'},
         update_test_suites.FetchCachedTestSuites())
 
     # Making a request to /udate_test_suites forces an update.
     self.testapp.post('/update_test_suites')
     self.assertEqual(
         {
             'dromaeo': {
                 'mas': {'Chromium': {'mac': False, 'win7': False}},
             },
             'scrolling': {
                 'mas': {'Chromium': {'mac': False, 'win7': False}},
             },
             'really': {
                 'mas': {'Chromium': {'mac': False, 'win7': False}},
             },
         },
         update_test_suites.FetchCachedTestSuites())
+    del request.registry['privileged_cached']

[benjhayden, 2016/09/19 22:14:53]

Is this needed?

[sullivan, 2016/09/20 02:19:32]

Done.

 
   def testPost_InternalOnly(self):
     self.SetCurrentUser('internal@chromium.org')
     self._AddSampleData()
     master_key = ndb.Key('Master', 'Chromium')
     graph_data.Bot(
         id='internal_mac', parent=master_key, internal_only=True).put()
     graph_data.TestMetadata(
         id='Chromium/internal_mac/internal_test', internal_only=True).put()
 
@@ skipping 146 matching lines @@
       test.description = 'Foo.'
       test.put()
       suites.append(test)
     self.assertEqual(
         {'dromaeo': 'Foo.'},
         update_test_suites._CreateSuiteDescriptionDict(suites))
 
 
 if __name__ == '__main__':
   unittest.main()