AudioBuffer: remove PadSilence()

AudioBuffer: remove PadSilence()

Turned out not to be needed. See
https://codereview.chromium.org/2343543002

Mostly a revert of the original CL
1f7c987fa3f0c0f715d13fd676cf44432a8a595b

... but I've maintained the removal of the unused Read*() methods/tests.

Committed: https://crrev.com/25f5454ae3e07606c679da80c5e39ab77a220b33
Cr-Commit-Position: refs/heads/master@{#419644}

[chcunningham, 2016-09-16 21:13:24]

chcunningham@chromium.org changed reviewers:
+ jrummell@chromium.org

[jrummell, 2016-09-16 23:28:00]

lgtm w/question.

https://codereview.chromium.org/2349873002/diff/1/media/base/audio_buffer.h
File media/base/audio_buffer.h (right):

https://codereview.chromium.org/2349873002/diff/1/media/base/audio_buffer.h#n...
media/base/audio_buffer.h:100: void ReadFramesInterleavedS32(int frames_to_copy,
int32_t* dest);
It appears these 2 headers got added back but not the code. Should they be left
out too?

[chcunningham, 2016-09-19 23:24:10]

The CQ bit was checked by chcunningham@chromium.org

[chcunningham, 2016-09-19 23:24:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org
Link to the patchset: https://codereview.chromium.org/2349873002/#ps20001
(title: "feedback: extra headers")

[commit-bot: I haz the power, 2016-09-19 23:24:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chcunningham, 2016-09-20 00:45:56]

https://codereview.chromium.org/2349873002/diff/1/media/base/audio_buffer.h
File media/base/audio_buffer.h (right):

https://codereview.chromium.org/2349873002/diff/1/media/base/audio_buffer.h#n...
media/base/audio_buffer.h:100: void ReadFramesInterleavedS32(int frames_to_copy,
int32_t* dest);
On 2016/09/16 23:28:00, jrummell wrote:
> It appears these 2 headers got added back but not the code. Should they be
left
> out too?

Nice catch. Weird that this still compiled. Removed these

[commit-bot: I haz the power, 2016-09-20 01:59:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 02:01:59]

Description was changed from

==========
AudioBuffer: remove PadSilence()

Turned out not to be needed. See
https://codereview.chromium.org/2343543002

Mostly a revert of the original CL
1f7c987fa3f0c0f715d13fd676cf44432a8a595b

... but I've maintained the removal of the unused Read*() methods/tests.
==========

to

==========
AudioBuffer: remove PadSilence()

Turned out not to be needed. See
https://codereview.chromium.org/2343543002

Mostly a revert of the original CL
1f7c987fa3f0c0f715d13fd676cf44432a8a595b

... but I've maintained the removal of the unused Read*() methods/tests.

Committed: https://crrev.com/25f5454ae3e07606c679da80c5e39ab77a220b33
Cr-Commit-Position: refs/heads/master@{#419644}
==========

[commit-bot: I haz the power, 2016-09-20 02:02:00]

Patchset 2 (id:??) landed as
https://crrev.com/25f5454ae3e07606c679da80c5e39ab77a220b33
Cr-Commit-Position: refs/heads/master@{#419644}