AudioBuffer: remove PadSilence()

media/base/audio_buffer_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include <limits>
 #include <memory>
 
 #include "media/base/audio_buffer.h"
 #include "media/base/audio_bus.h"
 #include "media/base/test_helpers.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace media {
 
 static const int kSampleRate = 4800;
 
 static void VerifyBusWithOffset(AudioBus* bus,
                                 int offset,
                                 int frames,
                                 float start,
                                 float start_offset,
                                 float increment) {
   for (int ch = 0; ch < bus->channels(); ++ch) {
     const float v = start_offset + start + ch * bus->frames() * increment;
-
     for (int i = offset; i < offset + frames; ++i) {
       ASSERT_FLOAT_EQ(v + i * increment, bus->channel(ch)[i]) << "i=" << i
                                                               << ", ch=" << ch;
     }
   }
 }
 
 static void VerifyBus(AudioBus* bus, int frames, float start, float increment) {
   VerifyBusWithOffset(bus, 0, frames, start, 0, increment);
 }
@@ skipping 113 matching lines @@
   buffer->ReadFrames(buffer->frame_count(), 0, 0, bus.get());
   VerifyBus(bus.get(), trim_start, 2 * trim_length, 1);
   VerifyBusWithOffset(bus.get(),
                       trim_start,
                       buffer->frame_count() - trim_start,
                       trim_length * 2,
                       trim_length * 2,
                       1);
 }
 
-void PadStartTest(SampleFormat sample_format) {
-  const ChannelLayout channel_layout = CHANNEL_LAYOUT_4_0;
-  const int channels = ChannelLayoutToChannelCount(channel_layout);
-  const int frames = 100;
-  const int silence_frames = frames / 5;
-  const base::TimeDelta start_time;
-  scoped_refptr<AudioBuffer> buffer =
-      MakeAudioBuffer<float>(sample_format, channel_layout, channels,
-                             kSampleRate, 0.0f, 1.0f, frames, start_time);
-
-  // Read all 100 frames from the buffer.
-  std::unique_ptr<AudioBus> bus = AudioBus::Create(channels, frames);
-  buffer->ReadFrames(frames, 0, 0, bus.get());
-  VerifyBus(bus.get(), frames, 0, 1);
-
-  // Now trim off some frames and add in leading silence.
-  buffer->TrimStart(silence_frames);
-  buffer->PadStart(silence_frames);
-
-  // Re-read. Verify first 20 frames of silence, next 80 frames same as before.
-  bus->Zero();
-  buffer->ReadFrames(frames, 0, 0, bus.get());
-  VerifyBus(bus.get(), silence_frames, 0, 0);
-  VerifyBusWithOffset(bus.get(), silence_frames, frames - silence_frames, 0, 0,
-                      1);
-
-  // Now trim off the silence. Verify silence is gone.
-  buffer->TrimStart(silence_frames);
-  bus->Zero();
-  buffer->ReadFrames(frames - silence_frames, 0, 0, bus.get());
-  VerifyBusWithOffset(bus.get(), 0, frames - silence_frames, silence_frames, 0,
-                      1);
-}
-
 TEST(AudioBufferTest, CopyFrom) {
   const ChannelLayout kChannelLayout = CHANNEL_LAYOUT_MONO;
   scoped_refptr<AudioBuffer> original_buffer = MakeAudioBuffer<uint8_t>(
       kSampleFormatU8, kChannelLayout,
       ChannelLayoutToChannelCount(kChannelLayout), kSampleRate, 1, 1,
       kSampleRate / 100, base::TimeDelta());
   scoped_refptr<AudioBuffer> new_buffer =
       AudioBuffer::CopyFrom(kSampleFormatU8,
                             original_buffer->channel_layout(),
                             original_buffer->channel_count(),
@@ skipping 257 matching lines @@
 }
 
 TEST(AudioBufferTest, TrimRangePlanar) {
   TrimRangeTest(kSampleFormatPlanarF32);
 }
 
 TEST(AudioBufferTest, TrimRangeInterleaved) {
   TrimRangeTest(kSampleFormatF32);
 }
 
-TEST(AudioBufferTest, PadStartPlanar) {
-  PadStartTest(kSampleFormatPlanarF32);
-}
-
-TEST(AudioBufferTest, PadStartInterleaved) {
-  PadStartTest(kSampleFormatF32);
-}
-
-TEST(AudioBufferTest, PadStartEmptyBuffer) {
-  const ChannelLayout channel_layout = CHANNEL_LAYOUT_4_0;
-  const int channels = ChannelLayoutToChannelCount(channel_layout);
-  const int frames = kSampleRate / 10;
-  const base::TimeDelta duration = base::TimeDelta::FromMilliseconds(100);
-  const base::TimeDelta start_time;
-  scoped_refptr<AudioBuffer> buffer = AudioBuffer::CreateEmptyBuffer(
-      channel_layout, channels, kSampleRate, frames, start_time);
-
-  // Empty buffer should zero data size with non-zero frame count and duration.
-  EXPECT_EQ(std::size_t{0}, buffer->data_size());
-  EXPECT_EQ(frames, buffer->frame_count());
-  EXPECT_EQ(duration, buffer->duration());
-
-  // Read all frames from the buffer. All data should be 0.
-  std::unique_ptr<AudioBus> bus = AudioBus::Create(channels, frames);
-  buffer->ReadFrames(frames, 0, 0, bus.get());
-  VerifyBus(bus.get(), frames, 0, 0);
-
-  // Double the number of frames by padding the start of the buffer with
-  // |frames| of silence.
-  buffer->PadStart(frames);
-  const int new_frame_count = frames * 2;
-  const base::TimeDelta new_duration = base::TimeDelta::FromMilliseconds(200);
-
-  // Adding silence should not trigger an allocation, but the frame count and
-  // duration should be increased.
-  EXPECT_EQ(std::size_t{0}, buffer->data_size());
-  EXPECT_EQ(new_frame_count, buffer->frame_count());
-  EXPECT_EQ(new_duration, buffer->duration());
-
-  // Read all frames from the buffer. All data should be 0.
-  bus = AudioBus::Create(channels, new_frame_count);
-  buffer->ReadFrames(new_frame_count, 0, 0, bus.get());
-  VerifyBus(bus.get(), new_frame_count, 0, 0);
-}
-
 }  // namespace media