AudioBuffer: remove PadSilence()

media/base/audio_buffer.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_AUDIO_BUFFER_H_
 #define MEDIA_BASE_AUDIO_BUFFER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 76 matching lines @@
   // Copy frames into |dest|. |frames_to_copy| is the number of frames to copy.
   // |source_frame_offset| specifies how many frames in the buffer to skip
   // first. |dest_frame_offset| is the frame offset in |dest|. The frames are
   // converted from their source format into planar float32 data (which is all
   // that AudioBus handles).
   void ReadFrames(int frames_to_copy,
                   int source_frame_offset,
                   int dest_frame_offset,
                   AudioBus* dest);
 
-  // Add |silence_frames| frames of silence to the start of the buffer. Silence
-  // padding can be removed using any of the Trim*() methods.
-  void PadStart(int silence_frames);
+  // Copy |frames_to_copy| frames into |dest|, |frames_to_copy| is the number of
+  // frames to copy. The frames are converted from their source format into
+  // interleaved int32_t.
+  void ReadFramesInterleavedS32(int frames_to_copy, int32_t* dest);

[jrummell, 2016/09/16 23:28:00]

It appears these 2 headers got added back but not the code. Should they be left
out too?

[chcunningham, 2016/09/20 00:45:56]

Nice catch. Weird that this still compiled. Removed these

+
+  // Copy |frames_to_copy| frames into |dest|, |frames_to_copy| is the number of
+  // frames to copy. The frames are converted from their source format into
+  // interleaved int16_t.
+  void ReadFramesInterleavedS16(int frames_to_copy, int16_t* dest);
 
   // Trim an AudioBuffer by removing |frames_to_trim| frames from the start.
   // Timestamp and duration are adjusted to reflect the fewer frames.
   // Note that repeated calls to TrimStart() may result in timestamp() and
   // duration() being off by a few microseconds due to rounding issues.
   void TrimStart(int frames_to_trim);
 
   // Trim an AudioBuffer by removing |frames_to_trim| frames from the end.
   // Duration is adjusted to reflect the fewer frames.
   void TrimEnd(int frames_to_trim);
@@ skipping 48 matching lines @@
               ChannelLayout channel_layout,
               int channel_count,
               int sample_rate,
               int frame_count,
               bool create_buffer,
               const uint8_t* const* data,
               const base::TimeDelta timestamp);
 
   virtual ~AudioBuffer();
 
-  void AllocateAndCopy(const uint8_t* const* data,
-                       int frame_count,
-                       int silence_frames);
-
   const SampleFormat sample_format_;
   const ChannelLayout channel_layout_;
   const int channel_count_;
   int sample_rate_;
   int adjusted_frame_count_;
   const bool end_of_stream_;
   base::TimeDelta timestamp_;
   base::TimeDelta duration_;
 
   // Contiguous block of channel data.
   std::unique_ptr<uint8_t, base::AlignedFreeDeleter> data_;
   size_t data_size_;
 
   // For planar data, points to each channels data.
   std::vector<uint8_t*> channel_data_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(AudioBuffer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_AUDIO_BUFFER_H_