Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2349283003:
Disable v8.todomvc on Samsung Galaxy S5s (Closed)
|
Created:
4 years, 3 months ago by charliea (OOO until 10-5) Modified:
4 years, 3 months ago CC:
chromium-reviews, jochen (gone - plz use gerrit), telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable v8.todomvc on Samsung Galaxy S5s
The benchmark is failing about 1/3 of the time on the S5s.
TBR=nednguyen@google.com
BUG=644826
Committed: https://crrev.com/953d22d019924c8fce8264512390fa6507ed34af
Cr-Commit-Position: refs/heads/master@{#419763}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 21 (11 generated)
Description was changed from ========== Disable v8.todomvc on Samsung Galaxy S5s The benchmark is failing about 1/3 of the time on the S5s. BUG=644826 ========== to ========== Disable v8.todomvc on Samsung Galaxy S5s The benchmark is failing about 1/3 of the time on the S5s. BUG=644826 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
charliea@chromium.org changed reviewers: + nednguyen@google.com
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Disable v8.todomvc on Samsung Galaxy S5s The benchmark is failing about 1/3 of the time on the S5s. BUG=644826 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disable v8.todomvc on Samsung Galaxy S5s The benchmark is failing about 1/3 of the time on the S5s. TBR=nednguyen@google.com BUG=644826 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Disable v8.todomvc on Samsung Galaxy S5s The benchmark is failing about 1/3 of the time on the S5s. TBR=nednguyen@google.com BUG=644826 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disable v8.todomvc on Samsung Galaxy S5s The benchmark is failing about 1/3 of the time on the S5s. TBR=nednguyen@google.com BUG=644826 ==========
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable v8.todomvc on Samsung Galaxy S5s The benchmark is failing about 1/3 of the time on the S5s. TBR=nednguyen@google.com BUG=644826 ========== to ========== Disable v8.todomvc on Samsung Galaxy S5s The benchmark is failing about 1/3 of the time on the S5s. TBR=nednguyen@google.com BUG=644826 Committed: https://crrev.com/953d22d019924c8fce8264512390fa6507ed34af Cr-Commit-Position: refs/heads/master@{#419763} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/953d22d019924c8fce8264512390fa6507ed34af Cr-Commit-Position: refs/heads/master@{#419763}
Message was sent while issue was closed.
prasadv@chromium.org changed reviewers: + prasadv@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2349283003/diff/1/tools/perf/benchmarks/v8.py File tools/perf/benchmarks/v8.py (right): https://codereview.chromium.org/2349283003/diff/1/tools/perf/benchmarks/v8.py... tools/perf/benchmarks/v8.py:133: return possible_browser.platform.GetDeviceTypeName() == 'SM-G900H' We still see v8.todomvc and v8.todomvc.reference benchmarks failing on https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... Is the device type correct? |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
