Disable v8.todomvc on Samsung Galaxy S5s

tools/perf/benchmarks/v8.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import os
 
 from core import path_util
 from core import perf_benchmark
 from page_sets import google_pages
 
 from benchmarks import v8_helper
@@ skipping 109 matching lines @@
   page_set = page_sets.TodoMVCPageSet
 
   def CreateTimelineBasedMeasurementOptions(self):
     return CreateV8TimelineBasedMeasurementOptions()
 
   @classmethod
   def Name(cls):
     return 'v8.todomvc'
 
   @classmethod
+  def ShouldDisable(cls, possible_browser):
+    # This benchmark is flaky on Samsung Galaxy S5s.
+    # http://crbug.com/644826
+    return possible_browser.platform.GetDeviceTypeName() == 'SM-G900H'

[prasadv, 2016/09/23 21:37:39]

We still see  v8.todomvc and  v8.todomvc.reference benchmarks failing on
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2...
Is the device type correct?

+
+  @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True
 
 
 # Disabled on reference builds because they don't support the new
 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
 @benchmark.Disabled('reference')
 class V8TodoMVCIgnition(V8TodoMVC):
   """Measures V8 Execution metrics on the TodoMVC examples using ignition."""
   page_set = page_sets.TodoMVCPageSet
@@ skipping 84 matching lines @@
       return True
     # http://crbug.com/623576
     if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or
         possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'):
       return True
     return False
 
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True