Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/benchmarks/v8.py

Issue 2349283003: Disable v8.todomvc on Samsung Galaxy S5s (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index 422580c41397663f3be4f4a19f6e53a6e4e6a138..25db8e949a4f66d776a0a678e79a66b936aa8a3c 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -127,6 +127,12 @@ class V8TodoMVC(perf_benchmark.PerfBenchmark):
return 'v8.todomvc'
@classmethod
+ def ShouldDisable(cls, possible_browser):
+ # This benchmark is flaky on Samsung Galaxy S5s.
+ # http://crbug.com/644826
+ return possible_browser.platform.GetDeviceTypeName() == 'SM-G900H'
prasadv 2016/09/23 21:37:39 We still see v8.todomvc and v8.todomvc.reference
+
+ @classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
return True
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698