Move towards using WorldImpact for codegen

Move towards using WorldImpact for codegen

CustomElementsAnalysis, TypeVariableHandler, LookupAnalysis and metadata
constants no longer require a [Registry] but instead collect their impact.

R=het@google.com, sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/0a79576ed057d73d25a322d5d0158dbd77a44819

Reverted:  https://github.com/dart-lang/sdk/commit/2a1ae8a3cecad9abf3a48a89f31a8aff96a4cb36
Committed: https://github.com/dart-lang/sdk/commit/bad12f912b0e4aea23dd4b83cb5d144ba75bcfe7

[Johnni Winther, 2016-09-19 13:27:44]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Harry Terkelsen, 2016-09-19 21:17:51]

het@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-09-19 21:17:53]

lgtm

https://codereview.chromium.org/2349163003/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2349163003/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:726: openWorld.closeWorld();
consider renaming 'closeWorld' to close?

https://codereview.chromium.org/2349163003/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2349163003/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:2411: dependency.constant,
impactBuilder, enqueuer.isResolutionQueue);
enqueuer.isResolutionQueue -> true?

https://codereview.chromium.org/2349163003/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:2421: dependency.constant,
impactBuilder, enqueuer.isResolutionQueue);
enqueuer.isResolutionQueue -> false?

https://codereview.chromium.org/2349163003/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_impact.dart (right):

https://codereview.chromium.org/2349163003/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_impact.dart:609: BackendImpact get
interceptorUse {
consider doing:
_interceptorUse ??= ...
instead

https://codereview.chromium.org/2349163003/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/world_impact.dart (right):

https://codereview.chromium.org/2349163003/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_impact.dart:72: // [Setlet]s?
Setlet -> Set

https://codereview.chromium.org/2349163003/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_impact.dart:79: if (_dynamicUses == null) {
you can also replace all of these with
_dynamicUses ??= new Setlet<DynamicUse>();

[Johnni Winther, 2016-09-21 10:31:43]

Description was changed from

==========
Move towards using WorldImpact for codegen

CustomElementsAnalysis, TypeVariableHandler, LookupAnalysis and metadata
constants no longer require a [Registry] but instead collect their impact.
==========

to

==========
Move towards using WorldImpact for codegen

CustomElementsAnalysis, TypeVariableHandler, LookupAnalysis and metadata
constants no longer require a [Registry] but instead collect their impact.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0a79576ed057d73d25a322d5d0158dbd77a44819
==========

[Johnni Winther, 2016-09-21 10:31:45]

Committed patchset #2 (id:20001) manually as
0a79576ed057d73d25a322d5d0158dbd77a44819 (presubmit successful).

[sra1, 2016-09-21 17:37:49]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2016-09-21 17:37:49]

I am going to revert this CL because it tanks the JSInterop and DromaeoDRT
benchmarks.

It appears that the generated code is now missing this line near the end of the
file:

    init.dispatchPropertyName = init.getIsolateTag("dispatch_record");

[sra1, 2016-09-21 17:42:26]

Description was changed from

==========
Move towards using WorldImpact for codegen

CustomElementsAnalysis, TypeVariableHandler, LookupAnalysis and metadata
constants no longer require a [Registry] but instead collect their impact.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0a79576ed057d73d25a322d5d0158dbd77a44819
==========

to

==========
Move towards using WorldImpact for codegen

CustomElementsAnalysis, TypeVariableHandler, LookupAnalysis and metadata
constants no longer require a [Registry] but instead collect their impact.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0a79576ed057d73d25a322d5d0158dbd77a44819

Reverted: 
https://github.com/dart-lang/sdk/commit/2a1ae8a3cecad9abf3a48a89f31a8aff96a4cb36
==========

[sra1, 2016-09-21 22:18:44]

On 2016/09/21 17:37:49, sra1 wrote:
> I am going to revert this CL because it tanks the JSInterop and DromaeoDRT
> benchmarks.
> 
> It appears that the generated code is now missing this line near the end of
the
> file:
> 
>     init.dispatchPropertyName = init.getIsolateTag("dispatch_record");

Test added: https://codereview.chromium.org/2360093002

[Johnni Winther, 2016-09-22 09:10:48]

PTAL @ at the last patch

[sra1, 2016-09-22 20:44:21]

lgtm

[Johnni Winther, 2016-09-23 08:43:18]

Description was changed from

==========
Move towards using WorldImpact for codegen

CustomElementsAnalysis, TypeVariableHandler, LookupAnalysis and metadata
constants no longer require a [Registry] but instead collect their impact.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0a79576ed057d73d25a322d5d0158dbd77a44819

Reverted: 
https://github.com/dart-lang/sdk/commit/2a1ae8a3cecad9abf3a48a89f31a8aff96a4cb36
==========

to

==========
Move towards using WorldImpact for codegen

CustomElementsAnalysis, TypeVariableHandler, LookupAnalysis and metadata
constants no longer require a [Registry] but instead collect their impact.

R=het@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0a79576ed057d73d25a322d5d0158dbd77a44819

Reverted: 
https://github.com/dart-lang/sdk/commit/2a1ae8a3cecad9abf3a48a89f31a8aff96a4cb36
Committed:
https://github.com/dart-lang/sdk/commit/bad12f912b0e4aea23dd4b83cb5d144ba75bcfe7
==========

[Johnni Winther, 2016-09-23 08:43:20]

Committed patchset #4 (id:60001) manually as
bad12f912b0e4aea23dd4b83cb5d144ba75bcfe7 (presubmit successful).