pkg/compiler/lib/src/js_backend/js_interop_analysis.dart - Issue 2349163003: Move towards using WorldImpact for codegen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

Issue 2349163003: Move towards using WorldImpact for codegen (Closed)

Patch Set: Reinsert missing features uses. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

diff --git a/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart b/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

index da89b34344692aaae40b30318508edbea62755d5..e43fb682c7b0248d42e6a9d2d3dd1b67aae24478 100644

--- a/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

+++ b/pkg/compiler/lib/src/js_backend/js_interop_analysis.dart

@@ -116,7 +116,7 @@ class JsInteropAnalysis {

// Skip classes that are completely unreachable. This should only happen

// when all of jsinterop types are unreachable from main.

- if (!backend.compiler.closedWorld.isImplemented(classElement)) return;

+ if (!backend.compiler.openWorld.isImplemented(classElement)) return;

if (!classElement.implementsInterface(helpers.jsJavaScriptObjectClass)) {

backend.reporter.reportErrorMessage(classElement,