Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2360093002: Add test for initialization of the native interceptor dispatch property. (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org, Harry Terkelsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test for initialization of the native interceptor dispatch property. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/8aba13e471eb729d7fab39a020927f65cb3733ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -4 lines) Patch
A tests/html/js_dispatch_property_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A + tests/html/js_dispatch_property_test.html View 1 chunk +1 line, -1 line 0 comments Download
A tests/html/js_dispatch_property_test_js.js View 1 chunk +17 lines, -0 lines 0 comments Download
A + tests/html/js_dispatch_property_test_lib.dart View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sra1
This test fails with your CL that I reverted.
4 years, 3 months ago (2016-09-21 21:15:34 UTC) #2
Harry Terkelsen
lgtm Add it as failing in the status file and submit?
4 years, 3 months ago (2016-09-21 21:19:58 UTC) #4
sra1
On 2016/09/21 21:19:58, Harry Terkelsen wrote: > lgtm > > Add it as failing in ...
4 years, 3 months ago (2016-09-21 22:00:43 UTC) #5
sra1
Committed patchset #1 (id:1) manually as 8aba13e471eb729d7fab39a020927f65cb3733ea (presubmit successful).
4 years, 3 months ago (2016-09-21 22:14:18 UTC) #7
Johnni Winther
4 years, 3 months ago (2016-09-22 09:11:46 UTC) #8
Message was sent while issue was closed.
On 2016/09/21 21:15:34, sra1 wrote:
> This test fails with your CL that I reverted.

Thanks for this, it made it very easy to find and fix the bug!

Powered by Google App Engine
This is Rietveld 408576698