Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2349103002: Include the RSA key modulus size in error message when it is too small. (Closed)

Created:
4 years, 3 months ago by eroman
Modified:
4 years, 3 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include the RSA key modulus size in error message when it is too small. BUG=634443 Committed: https://crrev.com/7d1b2033c814fa99f65956605536fe9704fc72ab Cr-Commit-Position: refs/heads/master@{#419602}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : address mattm's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -31 lines) Patch
M net/cert/internal/cert_error_params.h View 1 2 2 chunks +11 lines, -4 lines 0 comments Download
M net/cert/internal/cert_error_params.cc View 1 2 4 chunks +50 lines, -8 lines 0 comments Download
M net/cert/internal/signature_policy.cc View 1 2 4 chunks +16 lines, -17 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py View 1 chunk +2 lines, -0 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-by-512bit-rsa.pem View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
eroman
4 years, 3 months ago (2016-09-17 01:36:15 UTC) #4
mattm
https://codereview.chromium.org/2349103002/diff/1/net/cert/internal/cert_error_params.h File net/cert/internal/cert_error_params.h (right): https://codereview.chromium.org/2349103002/diff/1/net/cert/internal/cert_error_params.h#newcode66 net/cert/internal/cert_error_params.h:66: NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParamsSizeT( should decide on a consistent style ...
4 years, 3 months ago (2016-09-19 19:48:59 UTC) #7
eroman
https://codereview.chromium.org/2349103002/diff/1/net/cert/internal/cert_error_params.h File net/cert/internal/cert_error_params.h (right): https://codereview.chromium.org/2349103002/diff/1/net/cert/internal/cert_error_params.h#newcode66 net/cert/internal/cert_error_params.h:66: NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParamsSizeT( On 2016/09/19 19:48:59, mattm wrote: > ...
4 years, 3 months ago (2016-09-19 20:13:17 UTC) #10
mattm
lgtm
4 years, 3 months ago (2016-09-19 23:16:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349103002/40001
4 years, 3 months ago (2016-09-19 23:30:49 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-19 23:36:11 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 23:38:44 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7d1b2033c814fa99f65956605536fe9704fc72ab
Cr-Commit-Position: refs/heads/master@{#419602}

Powered by Google App Engine
This is Rietveld 408576698