Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Side by Side Diff: net/cert/internal/cert_error_params.cc

Issue 2349103002: Include the RSA key modulus size in error message when it is too small. (Closed)
Patch Set: address mattm's comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cert/internal/cert_error_params.h ('k') | net/cert/internal/signature_policy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/internal/cert_error_params.h" 5 #include "net/cert/internal/cert_error_params.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "net/der/input.h" 9 #include "net/der/input.h"
10 10
(...skipping 30 matching lines...) Expand all
41 std::string* out) { 41 std::string* out) {
42 *out += name; 42 *out += name;
43 *out += ": " + base::HexEncode(der.data(), der.size()); 43 *out += ": " + base::HexEncode(der.data(), der.size());
44 } 44 }
45 45
46 const char* name1_; 46 const char* name1_;
47 std::string der1_; 47 std::string der1_;
48 48
49 const char* name2_; 49 const char* name2_;
50 std::string der2_; 50 std::string der2_;
51
52 DISALLOW_COPY_AND_ASSIGN(CertErrorParams2Der);
51 }; 53 };
52 54
53 // Parameters subclass for describing (and pretty-printing) a single size_t. 55 // Parameters subclass for describing (and pretty-printing) a single size_t.
54 class CertErrorParamsSizeT : public CertErrorParams { 56 class CertErrorParams1SizeT : public CertErrorParams {
55 public: 57 public:
56 CertErrorParamsSizeT(const char* name, size_t value) 58 CertErrorParams1SizeT(const char* name, size_t value)
57 : name_(name), value_(value) {} 59 : name_(name), value_(value) {}
58 60
59 std::string ToDebugString() const override { 61 std::string ToDebugString() const override {
60 return name_ + std::string(": ") + base::SizeTToString(value_); 62 return name_ + std::string(": ") + base::SizeTToString(value_);
61 } 63 }
62 64
63 private: 65 private:
64 const char* name_; 66 const char* name_;
65 size_t value_; 67 size_t value_;
68
69 DISALLOW_COPY_AND_ASSIGN(CertErrorParams1SizeT);
70 };
71
72 // Parameters subclass for describing (and pretty-printing) two size_t
73 // values.
74 class CertErrorParams2SizeT : public CertErrorParams {
75 public:
76 CertErrorParams2SizeT(const char* name1,
77 size_t value1,
78 const char* name2,
79 size_t value2)
80 : name1_(name1), value1_(value1), name2_(name2), value2_(value2) {}
81
82 std::string ToDebugString() const override {
83 return name1_ + std::string(": ") + base::SizeTToString(value1_) + "\n" +
84 name2_ + std::string(": ") + base::SizeTToString(value2_);
85 }
86
87 private:
88 const char* name1_;
89 size_t value1_;
90 const char* name2_;
91 size_t value2_;
92
93 DISALLOW_COPY_AND_ASSIGN(CertErrorParams2SizeT);
66 }; 94 };
67 95
68 } // namespace 96 } // namespace
69 97
70 CertErrorParams::CertErrorParams() = default; 98 CertErrorParams::CertErrorParams() = default;
71 CertErrorParams::~CertErrorParams() = default; 99 CertErrorParams::~CertErrorParams() = default;
72 100
73 std::unique_ptr<CertErrorParams> CreateCertErrorParams1Der( 101 std::unique_ptr<CertErrorParams> CreateCertErrorParams1Der(
74 const char* name1, 102 const char* name,
75 const der::Input& der1) { 103 const der::Input& der) {
76 return base::MakeUnique<CertErrorParams2Der>(name1, der1, nullptr, 104 DCHECK(name);
105 return base::MakeUnique<CertErrorParams2Der>(name, der, nullptr,
77 der::Input()); 106 der::Input());
78 } 107 }
79 108
80 std::unique_ptr<CertErrorParams> CreateCertErrorParams2Der( 109 std::unique_ptr<CertErrorParams> CreateCertErrorParams2Der(
81 const char* name1, 110 const char* name1,
82 const der::Input& der1, 111 const der::Input& der1,
83 const char* name2, 112 const char* name2,
84 const der::Input& der2) { 113 const der::Input& der2) {
114 DCHECK(name1);
115 DCHECK(name2);
85 return base::MakeUnique<CertErrorParams2Der>(name1, der1, name2, der2); 116 return base::MakeUnique<CertErrorParams2Der>(name1, der1, name2, der2);
86 } 117 }
87 118
88 std::unique_ptr<CertErrorParams> CreateCertErrorParamsSizeT(const char* name, 119 std::unique_ptr<CertErrorParams> CreateCertErrorParams1SizeT(const char* name,
89 size_t value) { 120 size_t value) {
90 return base::MakeUnique<CertErrorParamsSizeT>(name, value); 121 DCHECK(name);
122 return base::MakeUnique<CertErrorParams1SizeT>(name, value);
123 }
124
125 NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParams2SizeT(
126 const char* name1,
127 size_t value1,
128 const char* name2,
129 size_t value2) {
130 DCHECK(name1);
131 DCHECK(name2);
132 return base::MakeUnique<CertErrorParams2SizeT>(name1, value1, name2, value2);
91 } 133 }
92 134
93 } // namespace net 135 } // namespace net
OLDNEW
« no previous file with comments | « net/cert/internal/cert_error_params.h ('k') | net/cert/internal/signature_policy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698