Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: net/cert/internal/cert_error_params.cc

Issue 2349103002: Include the RSA key modulus size in error message when it is too small. (Closed)
Patch Set: address mattm's comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/cert_error_params.h ('k') | net/cert/internal/signature_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/cert_error_params.cc
diff --git a/net/cert/internal/cert_error_params.cc b/net/cert/internal/cert_error_params.cc
index 08ddfca062d184ce9dfb9d70cb17ea7e2b4954b5..29730602a093fb7a76635d26695576a473a42069 100644
--- a/net/cert/internal/cert_error_params.cc
+++ b/net/cert/internal/cert_error_params.cc
@@ -48,12 +48,14 @@ class CertErrorParams2Der : public CertErrorParams {
const char* name2_;
std::string der2_;
+
+ DISALLOW_COPY_AND_ASSIGN(CertErrorParams2Der);
};
// Parameters subclass for describing (and pretty-printing) a single size_t.
-class CertErrorParamsSizeT : public CertErrorParams {
+class CertErrorParams1SizeT : public CertErrorParams {
public:
- CertErrorParamsSizeT(const char* name, size_t value)
+ CertErrorParams1SizeT(const char* name, size_t value)
: name_(name), value_(value) {}
std::string ToDebugString() const override {
@@ -63,6 +65,32 @@ class CertErrorParamsSizeT : public CertErrorParams {
private:
const char* name_;
size_t value_;
+
+ DISALLOW_COPY_AND_ASSIGN(CertErrorParams1SizeT);
+};
+
+// Parameters subclass for describing (and pretty-printing) two size_t
+// values.
+class CertErrorParams2SizeT : public CertErrorParams {
+ public:
+ CertErrorParams2SizeT(const char* name1,
+ size_t value1,
+ const char* name2,
+ size_t value2)
+ : name1_(name1), value1_(value1), name2_(name2), value2_(value2) {}
+
+ std::string ToDebugString() const override {
+ return name1_ + std::string(": ") + base::SizeTToString(value1_) + "\n" +
+ name2_ + std::string(": ") + base::SizeTToString(value2_);
+ }
+
+ private:
+ const char* name1_;
+ size_t value1_;
+ const char* name2_;
+ size_t value2_;
+
+ DISALLOW_COPY_AND_ASSIGN(CertErrorParams2SizeT);
};
} // namespace
@@ -71,9 +99,10 @@ CertErrorParams::CertErrorParams() = default;
CertErrorParams::~CertErrorParams() = default;
std::unique_ptr<CertErrorParams> CreateCertErrorParams1Der(
- const char* name1,
- const der::Input& der1) {
- return base::MakeUnique<CertErrorParams2Der>(name1, der1, nullptr,
+ const char* name,
+ const der::Input& der) {
+ DCHECK(name);
+ return base::MakeUnique<CertErrorParams2Der>(name, der, nullptr,
der::Input());
}
@@ -82,12 +111,25 @@ std::unique_ptr<CertErrorParams> CreateCertErrorParams2Der(
const der::Input& der1,
const char* name2,
const der::Input& der2) {
+ DCHECK(name1);
+ DCHECK(name2);
return base::MakeUnique<CertErrorParams2Der>(name1, der1, name2, der2);
}
-std::unique_ptr<CertErrorParams> CreateCertErrorParamsSizeT(const char* name,
- size_t value) {
- return base::MakeUnique<CertErrorParamsSizeT>(name, value);
+std::unique_ptr<CertErrorParams> CreateCertErrorParams1SizeT(const char* name,
+ size_t value) {
+ DCHECK(name);
+ return base::MakeUnique<CertErrorParams1SizeT>(name, value);
+}
+
+NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParams2SizeT(
+ const char* name1,
+ size_t value1,
+ const char* name2,
+ size_t value2) {
+ DCHECK(name1);
+ DCHECK(name2);
+ return base::MakeUnique<CertErrorParams2SizeT>(name1, value1, name2, value2);
}
} // namespace net
« no previous file with comments | « net/cert/internal/cert_error_params.h ('k') | net/cert/internal/signature_policy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698