Change the interface for parsing SignatureAlgorithm to take a

net/cert/internal/signature_algorithm.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/signature_algorithm.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 519 matching lines @@
 }
 
 RsaPssParameters::RsaPssParameters(DigestAlgorithm mgf1_hash,
                                    uint32_t salt_length)
     : mgf1_hash_(mgf1_hash), salt_length_(salt_length) {
 }
 
 SignatureAlgorithm::~SignatureAlgorithm() {
 }
 
-std::unique_ptr<SignatureAlgorithm> SignatureAlgorithm::CreateFromDer(
-    const der::Input& algorithm_identifier) {
+std::unique_ptr<SignatureAlgorithm> SignatureAlgorithm::Create(
+    const der::Input& algorithm_identifier,
+    CertErrors* errors) {
+  // TODO(crbug.com/634443): Add useful error information.
+
   der::Input oid;
   der::Input params;
   if (!ParseAlgorithmIdentifier(algorithm_identifier, &oid, &params))
     return nullptr;
 
   // TODO(eroman): Each OID is tested for equality in order, which is not
   // particularly efficient.
 
   if (oid == der::Input(kOidSha1WithRsaEncryption))
     return ParseRsaPkcs1(DigestAlgorithm::Sha1, params);
@@ skipping 18 matching lines @@
 
   if (oid == der::Input(kOidEcdsaWithSha512))
     return ParseEcdsa(DigestAlgorithm::Sha512, params);
 
   if (oid == der::Input(kOidRsaSsaPss))
     return ParseRsaPss(params);
 
   if (oid == der::Input(kOidSha1WithRsaSignature))
     return ParseRsaPkcs1(DigestAlgorithm::Sha1, params);
 
+  // TODO(crbug.com/634443): Add an error indicating what the OID
+  // was.
+
   return nullptr;  // Unsupported OID.
 }
 
 std::unique_ptr<SignatureAlgorithm> SignatureAlgorithm::CreateRsaPkcs1(
     DigestAlgorithm digest) {
   return base::WrapUnique(
       new SignatureAlgorithm(SignatureAlgorithmId::RsaPkcs1, digest, nullptr));
 }
 
 std::unique_ptr<SignatureAlgorithm> SignatureAlgorithm::CreateEcdsa(
@@ skipping 17 matching lines @@
   return nullptr;
 }
 
 SignatureAlgorithm::SignatureAlgorithm(
     SignatureAlgorithmId algorithm,
     DigestAlgorithm digest,
     std::unique_ptr<SignatureAlgorithmParameters> params)
     : algorithm_(algorithm), digest_(digest), params_(std::move(params)) {}
 
 }  // namespace net