Index: net/cert/internal/signature_algorithm.cc |
diff --git a/net/cert/internal/signature_algorithm.cc b/net/cert/internal/signature_algorithm.cc |
index e9bc3c536fa3694eb3c1ed688724e2be2415198c..0a1b0e610edd09456d74cb6fd793cf00cfcb5011 100644 |
--- a/net/cert/internal/signature_algorithm.cc |
+++ b/net/cert/internal/signature_algorithm.cc |
@@ -537,8 +537,11 @@ RsaPssParameters::RsaPssParameters(DigestAlgorithm mgf1_hash, |
SignatureAlgorithm::~SignatureAlgorithm() { |
} |
-std::unique_ptr<SignatureAlgorithm> SignatureAlgorithm::CreateFromDer( |
- const der::Input& algorithm_identifier) { |
+std::unique_ptr<SignatureAlgorithm> SignatureAlgorithm::Create( |
+ const der::Input& algorithm_identifier, |
+ CertErrors* errors) { |
+ // TODO(crbug.com/634443): Add useful error information. |
+ |
der::Input oid; |
der::Input params; |
if (!ParseAlgorithmIdentifier(algorithm_identifier, &oid, ¶ms)) |
@@ -577,6 +580,9 @@ std::unique_ptr<SignatureAlgorithm> SignatureAlgorithm::CreateFromDer( |
if (oid == der::Input(kOidSha1WithRsaSignature)) |
return ParseRsaPkcs1(DigestAlgorithm::Sha1, params); |
+ // TODO(crbug.com/634443): Add an error indicating what the OID |
+ // was. |
+ |
return nullptr; // Unsupported OID. |
} |