Blimp Settings framework on the c++ side

blimp/client/core/settings/settings_observer.h

Index: blimp/client/core/settings/settings_observer.h
diff --git a/blimp/client/core/settings/settings_observer.h b/blimp/client/core/settings/settings_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..d7464ceda7dfcc59c1ca11061691f88311748cc4
--- /dev/null
+++ b/blimp/client/core/settings/settings_observer.h
@@ -0,0 +1,30 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_CLIENT_CORE_SETTINGS_SETTINGS_OBSERVER_H_
+#define BLIMP_CLIENT_CORE_SETTINGS_SETTINGS_OBSERVER_H_
+
+#include "base/observer_list.h"

[David Trainor- moved to gerrit, 2016/09/27 04:10:06]

Remove this?

[Menglin, 2016/09/30 23:48:57]

Done.

+
+namespace blimp {
+namespace client {
+
+class SettingsObserver {
+ public:
+  virtual ~SettingsObserver() = default;
+  virtual void OnShowNetworkStatsChanged(bool enable) {}
+  virtual void OnRecordWholeDocumentChanged(bool enable) {}
+  virtual void OnRestartRequired() {}
+
+ protected:
+  SettingsObserver() {}

[David Trainor- moved to gerrit, 2016/09/27 04:10:06]

try = default on this too?

[Menglin, 2016/09/30 23:48:57]

I am passing a Settings* to the constructor. please see the updated code

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SettingsObserver);
+};
+
+}  // namespace client
+}  // namespace blimp
+
+#endif  // BLIMP_CLIENT_CORE_SETTINGS_SETTINGS_OBSERVER_H_