Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: blimp/client/core/settings/settings_feature.cc

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/settings/settings_feature.cc
diff --git a/blimp/client/core/settings/settings_feature.cc b/blimp/client/core/settings/settings_feature.cc
index d2e9d1d8b3045c2325b4a98d352ad835002315a9..bb0ff94d245f1650005b3de160a2a4bc19298aeb 100644
--- a/blimp/client/core/settings/settings_feature.cc
+++ b/blimp/client/core/settings/settings_feature.cc
@@ -12,7 +12,7 @@
namespace blimp {
namespace client {
-SettingsFeature::SettingsFeature() : record_whole_document_(false) {}
+SettingsFeature::SettingsFeature() {}
SettingsFeature::~SettingsFeature() {}
@@ -22,14 +22,9 @@ void SettingsFeature::set_outgoing_message_processor(
}
void SettingsFeature::SetRecordWholeDocument(bool record_whole_document) {
- if (record_whole_document_ == record_whole_document)
- return;
-
- record_whole_document_ = record_whole_document;
-
EngineSettingsMessage* engine_settings;
std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&engine_settings);
- engine_settings->set_record_whole_document(record_whole_document_);
+ engine_settings->set_record_whole_document(record_whole_document);
outgoing_message_processor_->ProcessMessage(std::move(message),
net::CompletionCallback());
}

Powered by Google App Engine
This is Rietveld 408576698