Blimp Settings framework on the c++ side

blimp/client/core/settings/settings_unittest.cc

Index: blimp/client/core/settings/settings_unittest.cc
diff --git a/blimp/client/core/settings/settings_unittest.cc b/blimp/client/core/settings/settings_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0d74ca4662ddb96b33c42d7d5b4fab3caaf72a0b
--- /dev/null
+++ b/blimp/client/core/settings/settings_unittest.cc
@@ -0,0 +1,101 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "blimp/client/core/settings/settings.h"
+
+#include "base/command_line.h"
+#include "blimp/client/core/blimp_client_switches.h"
+#include "blimp/client/core/settings/settings_observer.h"
+#include "blimp/client/core/settings/settings_prefs.h"
+#include "components/prefs/testing_pref_service.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::_;
+
+namespace blimp {
+namespace client {
+namespace {
+
+class MockSettingsObserver : public SettingsObserver {
+ public:
+  MockSettingsObserver() : SettingsObserver() {}
+  ~MockSettingsObserver() override = default;
+
+  MOCK_METHOD1(OnShowNetworkStatsChanged, void(bool));

[David Trainor- moved to gerrit, 2016/09/27 04:10:06]

What about enable?

[Menglin, 2016/09/30 23:48:57]

Done.

+  MOCK_METHOD1(OnRecordWholeDocumentChanged, void(bool));
+  MOCK_METHOD0(OnRestartRequired, void());
+};
+
+class SettingsTest : public testing::Test {
+ public:
+  SettingsTest() : settings_(&prefs_) {
+    Settings::RegisterPrefs(prefs_.registry());
+    std::unique_ptr<MockSettingsObserver> observer_uniqueptr =
+        base::MakeUnique<MockSettingsObserver>();
+    observer_ = observer_uniqueptr.get();
+
+    settings_.AddObserver(std::move(observer_uniqueptr));
+  }
+
+  ~SettingsTest() override {}

[David Trainor- moved to gerrit, 2016/09/27 04:10:06]

= default?

[Menglin, 2016/09/30 23:48:57]

Done.

+
+  MockSettingsObserver* observer_;

[David Trainor- moved to gerrit, 2016/09/27 04:10:07]

make this the unique_ptr once you move AddObserver to take raw pointers?

[Menglin, 2016/09/30 23:48:57]

Since I moved InitializeFromCommandLineAndPref to Settings' constructor, I need
to test the constructor as well. So I'm moving settings_ and observer_ out of
the SettingsTest to be able to test the constructor with command line
configured.

[David Trainor- moved to gerrit, 2016/10/01 03:26:34]

sg!

+  Settings settings_;
+  TestingPrefServiceSimple prefs_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SettingsTest);
+};
+
+TEST_F(SettingsTest, TestSetShowNetworkStats) {
+  EXPECT_CALL(*observer_, OnShowNetworkStatsChanged(false)). Times(1);

[David Trainor- moved to gerrit, 2016/09/27 04:10:07]

If we don't expect calls on sets to the same value, validate that the initial
value is as expected too and that calls to set the same value don't trigger an
observer call?

[Menglin, 2016/09/30 23:48:57]

Done.

+  settings_.SetShowNetworkStats(false);
+  EXPECT_CALL(*observer_, OnShowNetworkStatsChanged(true)). Times(1);
+  settings_.SetShowNetworkStats(true);
+}
+
+TEST_F(SettingsTest, TestSetEnableBlimpMode) {
+  EXPECT_FALSE(prefs_.GetBoolean(prefs::kBlimpEnabled));
+  EXPECT_CALL(*observer_, OnRestartRequired()).Times(3);
+
+  settings_.SetEnableBlimpMode(false);
+  settings_.SetEnableBlimpMode(true);
+  EXPECT_TRUE(prefs_.GetBoolean(prefs::kBlimpEnabled));
+  settings_.SetEnableBlimpMode(false);
+  EXPECT_FALSE(prefs_.GetBoolean(prefs::kBlimpEnabled));
+}
+
+TEST_F(SettingsTest, TestSetRecordWholeDocument) {
+  EXPECT_FALSE(prefs_.GetBoolean(prefs::kRecordWholeDocument));
+
+  EXPECT_CALL(*observer_, OnRecordWholeDocumentChanged(_)).Times(0);
+  settings_.SetRecordWholeDocument(false);
+
+  EXPECT_CALL(*observer_, OnRecordWholeDocumentChanged(true)).Times(1);
+  settings_.SetRecordWholeDocument(true);
+  EXPECT_TRUE(prefs_.GetBoolean(prefs::kRecordWholeDocument));
+
+  EXPECT_CALL(*observer_, OnRecordWholeDocumentChanged(false)).Times(1);
+  settings_.SetRecordWholeDocument(false);
+  EXPECT_FALSE(prefs_.GetBoolean(prefs::kRecordWholeDocument));
+}
+
+TEST_F(SettingsTest, TestInitializeFromCommandLineAndPref) {
+  auto* cmd_line = base::CommandLine::ForCurrentProcess();
+
+  EXPECT_CALL(*observer_, OnRecordWholeDocumentChanged(_)).Times(0);
+  cmd_line->AppendSwitch(switches::kEnableBlimp);
+  settings_.InitializeFromCommandLineAndPref();
+  EXPECT_TRUE(settings_.blimp_enabled());
+
+  EXPECT_CALL(*observer_, OnRecordWholeDocumentChanged(true)).Times(1);
+  cmd_line->AppendSwitch(switches::kDownloadWholeDocument);
+  settings_.InitializeFromCommandLineAndPref();
+  EXPECT_TRUE(prefs_.GetBoolean(prefs::kRecordWholeDocument));
+}
+
+}  // namespace
+}  // namespace client
+}  // namespace blimp