Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 23486008: Fix wrong description of chrome.commands example. (Closed)

Created:
7 years, 3 months ago by zhchbin
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix wrong description of chrome.commands example. BUG=NONE NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220946

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/docs/examples/api/commands/manifest.json View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
zhchbin
Please review. https://codereview.chromium.org/23486008/diff/1/chrome/common/extensions/docs/examples/api/commands/manifest.json File chrome/common/extensions/docs/examples/api/commands/manifest.json (right): https://codereview.chromium.org/23486008/diff/1/chrome/common/extensions/docs/examples/api/commands/manifest.json#newcode20 chrome/common/extensions/docs/examples/api/commands/manifest.json:20: "default": "Ctrl+Shift+F", The browser action of this ...
7 years, 3 months ago (2013-09-01 02:44:12 UTC) #1
not at google - send to devlin
lgtm
7 years, 3 months ago (2013-09-03 14:37:48 UTC) #2
not at google - send to devlin
(thanks - much appreciated)
7 years, 3 months ago (2013-09-03 14:37:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/23486008/1
7 years, 3 months ago (2013-09-03 15:21:28 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 15:21:45 UTC) #5
Message was sent while issue was closed.
Change committed as 220946

Powered by Google App Engine
This is Rietveld 408576698