Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: chrome/common/extensions/docs/examples/api/commands/manifest.json

Issue 23486008: Fix wrong description of chrome.commands example. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 "name": "Sample Extension Commands extension", 2 "name": "Sample Extension Commands extension",
3 "description": "Press Ctrl+F to open the browser action popup, press Ctrl+Shif t+Y to send an event (Command+Shift+Y on a Mac).", 3 "description": "Press Ctrl+Shift+F (Command+Shift+F on a Mac) to open the brow ser action popup, press Ctrl+Shift+Y to send an event (Command+Shift+Y on a Mac) .",
4 "version": "1.0", 4 "version": "1.0",
5 "manifest_version": 2, 5 "manifest_version": 2,
6 "background": { 6 "background": {
7 "scripts": ["background.js"], 7 "scripts": ["background.js"],
8 "persistent": false 8 "persistent": false
9 }, 9 },
10 "browser_action": { 10 "browser_action": {
11 "default_popup": "browser_action.html" 11 "default_popup": "browser_action.html"
12 }, 12 },
13 "commands": { 13 "commands": {
14 "toggle-feature": { 14 "toggle-feature": {
15 "suggested_key": { "default": "Ctrl+Shift+Y" }, 15 "suggested_key": { "default": "Ctrl+Shift+Y" },
16 "description": "Send a 'toggle-feature' event to the extension" 16 "description": "Send a 'toggle-feature' event to the extension"
17 }, 17 },
18 "_execute_browser_action": { 18 "_execute_browser_action": {
19 "suggested_key": { 19 "suggested_key": {
20 "default": "Ctrl+Shift+F", 20 "default": "Ctrl+Shift+F",
zhchbin 2013/09/01 02:44:12 The browser action of this example is using "Ctrl+
21 "mac": "MacCtrl+Shift+F" 21 "mac": "MacCtrl+Shift+F"
22 } 22 }
23 } 23 }
24 } 24 }
25 } 25 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698