Cleanup Socket class and remove it from the platform files.

Cleanup Socket class and remove it from the platform files.

Move the Socket class to dedicated platform/socket.{cc,h} files.
Cleaned up the implementation to allow for more code sharing.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16521

[Benedikt Meurer, 2013-09-03 13:19:37]

Hey Toon,
Another mostly mechanical cleanup, PTAL.
-- Benedikt

[Toon Verwaest, 2013-09-03 13:56:19]

lgtm

[tfarina, 2013-09-03 19:36:34]

https://codereview.chromium.org/23484014/diff/7001/src/platform.h
File src/platform.h (right):

https://codereview.chromium.org/23484014/diff/7001/src/platform.h#newcode411
src/platform.h:411: class VirtualMemory {
is the goal to move all these classes into their separate headers? Are you going
to move VirtualMemory and Thread next, to src/platform/?

[Sven Panne, 2013-09-04 06:50:16]

On 2013/09/03 19:36:34, tfarina wrote:
> https://codereview.chromium.org/23484014/diff/7001/src/platform.h
> File src/platform.h (right):
> 
> https://codereview.chromium.org/23484014/diff/7001/src/platform.h#newcode411
> src/platform.h:411: class VirtualMemory {
> is the goal to move all these classes into their separate headers? Are you
going
> to move VirtualMemory and Thread next, to src/platform/?

I don't think we have a detailed plan which class comes next, but in general:
Yes. Instead of the fundamentally broken platform-foo.* mess, we move to the
usual autoconf-style way of handling platform dependencies via feature
#defines/#ifs.

That this is a lessons learned by almost all projects, even if it sometimes
takes decades: http://en.wikipedia.org/wiki/Imake  ;-)

[Benedikt Meurer, 2013-09-04 10:41:08]

On 2013/09/04 06:50:16, Sven Panne wrote:
> On 2013/09/03 19:36:34, tfarina wrote:
> > https://codereview.chromium.org/23484014/diff/7001/src/platform.h
> > File src/platform.h (right):
> > 
> > https://codereview.chromium.org/23484014/diff/7001/src/platform.h#newcode411
> > src/platform.h:411: class VirtualMemory {
> > is the goal to move all these classes into their separate headers? Are you
> going
> > to move VirtualMemory and Thread next, to src/platform/?
> 
> I don't think we have a detailed plan which class comes next, but in general:
> Yes. Instead of the fundamentally broken platform-foo.* mess, we move to the
> usual autoconf-style way of handling platform dependencies via feature
> #defines/#ifs.

VirtualMemory is next. :-)

> That this is a lessons learned by almost all projects, even if it sometimes
> takes decades: http://en.wikipedia.org/wiki/Imake  ;-)

Well it's no necessarily autotools-style. With autotools, I used to split stuff
into separate platform files usually (i.e. file.h, file.c, file-win.c,
file-unix.c), but since GYP is far from autotools/cmake/whatever, we'll have to
live with the since .cc file approach. Given our usually small platform classes,
this is not a big issue.

[Benedikt Meurer, 2013-09-04 10:42:09]

Committed patchset #2 manually as r16521.